Re: [ptxdist] [PATCH] ptxd_make_fit_image: Add mandatory properties

[Alex Vazquez <avazquez.dev@gmail.com>]

El mié., 11 nov. 2020 a las 9:59, Sascha Hauer
(<s.hauer@pengutronix.de>) escribió:
>
> On Wed, Nov 11, 2020 at 09:47:42AM +0100, Alex Vazquez wrote:
> >    According to the FIT image specification, these properties are mandatory.
> >    [1]https://gitlab.denx.de/u-boot/u-boot/-/blob/master/doc/uImage.FIT/source_file_format.txt
>
> Putting a load address into the FIT image means that the image can run
> only on boards which have SDRAM there. We can build zImages which run on
> a variety of different boards and SoCs, so to me it doesn't make sense
> to limit this image to a single board only forced the container format.
> For this reason barebox deliberately ignores the absence of these
> properties.
> That said, you shouldn't set these properties when not explicitly wanted
> by the user, so the default should be that the properties are not there.
>
Hi, Sascha.

Ok, I will do load/entry addresses optional.
I am going to generate a new patch v2.

Thanks!

> Sascha
>
> >    I have verified that u-boot fails to boot if these properties are not
> >    specified
> >    ## Loading kernel from FIT Image at c2000000 ...
> >       Using 'conf-1' configuration
> >       Trying 'kernel' kernel subimage
> >         Description:  kernel
> >         Created:      2020-09-01   0:00:00 UTC
> >         Type:         Kernel Image
> >         Compression:  uncompressed
> >         Data Start:   0xc20000b4
> >         Data Size:    7329320 Bytes = 7 MiB
> >         Architecture: ARM
> >         OS:           Linux
> >         Load Address: unavailable
> >         Entry Point:  unavailable
> >         Hash algo:    sha256
> >         Hash value:
> >    1d5ceba5d651e2b9bede9945427a7b759fe4891812eb9a67c53ecd4544c8fae8
> >       Verifying Hash Integrity ... sha256+ OK
> >    Can't get image load address!
> >    Regards, Alex
> >
> >    El mar., 10 nov. 2020 a las 15:38, Denis Osterland-Heim
> >    (<[2]denis.osterland@diehl.com>) escribió:
> >
> >      Hi,
> >
> >      AFAIK bootloaders should have reasonable defaults for this values.
> >      So they should be optional.
> >
> >      Regrads, Denis
> >
> >      Am Dienstag, den 10.11.2020, 10:11 +0100 schrieb
> >      [3]avazquez.dev@gmail.com:
> >      > From: AVazquez <[4]avazquez.dev@gmail.com>
> >      >
> >      > Add mandatory properties for types kernel and ramdisk.
> >      >
> >      > Signed-off-by: AVazquez <[5]avazquez.dev@gmail.com>
> >      > ---
> >      >  platforms/[6]kernel-fit.in            | 10 ++++++++++
> >      >  scripts/lib/ptxd_make_fit_image.sh |  4 ++++
> >      >  2 files changed, 14 insertions(+)
> >      >
> >      > diff --git a/platforms/[7]kernel-fit.in b/platforms/[8]kernel-fit.in
> >      > index 8cbc1a8..d917a97 100644
> >      > --- a/platforms/[9]kernel-fit.in
> >      > +++ b/platforms/[10]kernel-fit.in
> >      > @@ -17,6 +17,16 @@ menuconfig KERNEL_FIT
> >      >
> >      >  if KERNEL_FIT
> >      >
> >      > +config KERNEL_FIT_LOAD
> >      > +string
> >      > +default "0xC0008000"
> >      > +prompt "Kernel load address"
> >      > +
> >      > +config KERNEL_FIT_ENTRY
> >      > +string
> >      > +default "0xC0008000"
> >      > +prompt "Kernel entry address"
> >      > +
> >      >  config KERNEL_FIT_SIGNED
> >      >  bool
> >      >  prompt "sign FIT image"
> >      > diff --git a/scripts/lib/ptxd_make_fit_image.sh
> >      b/scripts/lib/ptxd_make_fit_image.sh
> >      > index 9754d1e..4314b0e 100644
> >      > --- a/scripts/lib/ptxd_make_fit_image.sh
> >      > +++ b/scripts/lib/ptxd_make_fit_image.sh
> >      > @@ -21,7 +21,10 @@ ptxd_make_image_fit_its() {
> >      >  data = /incbin/("${image_kernel}");
> >      >  type = "kernel";
> >      >  arch = "$(ptxd_get_ptxconf PTXCONF_ARCH_STRING)";
> >      > +os = "linux";
> >      >  compression = "none";
> >      > +load = <$(ptxd_get_ptxconf PTXCONF_KERNEL_FIT_LOAD)>;
> >      > +entry = <$(ptxd_get_ptxconf PTXCONF_KERNEL_FIT_ENTRY)>;
> >      >  hash-1 {
> >      >  algo = "sha256";
> >      >  };
> >      > @@ -33,6 +36,7 @@ EOF
> >      >  description = "initramfs";
> >      >  data = /incbin/("${image_initramfs}");
> >      >  type = "ramdisk";
> >      > +os = "linux";
> >      >  compression = "none";
> >      >  hash-1 {
> >      >  algo = "sha256";
> >      Diehl Connectivity Solutions GmbH
> >      Geschäftsführung: Horst Leonberger
> >      Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> >      Nürnberg: HRB 32315
> >
> >      ________________________________
> >
> >      Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese
> >      E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte
> >      Informationen.
> >      Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise
> >      erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> >      Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung,
> >      Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> >
> >      - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten
> >      Sie unter:
> >
> >      [11]https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> >
> >      The contents of the above mentioned e-mail is not legally binding. This
> >      e-mail contains confidential and/or legally protected information.
> >      Please inform us if you have received this e-mail by
> >      mistake and delete it in such a case. Each unauthorized reproduction,
> >      disclosure, alteration, distribution and/or publication of this e-mail
> >      is strictly prohibited.
> >
> >      - For general information on data protection and your respective rights
> >      please visit:
> >
> >      [12]https://www.diehl.com/group/en/transparency-and-information-obligations/
> >
> >      _______________________________________________
> >      ptxdist mailing list
> >      [13]ptxdist@pengutronix.de
> >      To unsubscribe, send a mail with subject "unsubscribe" to
> >      [14]ptxdist-request@pengutronix.de
> >
> > References
> >
> >    Visible links
> >    1. https://gitlab.denx.de/u-boot/u-boot/-/blob/master/doc/uImage.FIT/source_file_format.txt
> >    2. mailto:denis.osterland@diehl.com
> >    3. mailto:avazquez.dev@gmail.com
> >    4. mailto:avazquez.dev@gmail.com
> >    5. mailto:avazquez.dev@gmail.com
> >    6. http://kernel-fit.in/
> >    7. http://kernel-fit.in/
> >    8. http://kernel-fit.in/
> >    9. http://kernel-fit.in/
> >   10. http://kernel-fit.in/
> >   11. https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> >   12. https://www.diehl.com/group/en/transparency-and-information-obligations/
> >   13. mailto:ptxdist@pengutronix.de
> >   14. mailto:ptxdist-request@pengutronix.de
>
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de