mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Alejandro Vazquez <avazquez.dev@gmail.com>
To: Alejandro Vazquez <avazquez.dev@gmail.com>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] u-boot: Add support for u-boot.dtb and u-boot-nodtb.bin
Date: Sun, 3 Oct 2021 21:52:06 +0200	[thread overview]
Message-ID: <CAOTEMUQ38fNGH+-gV01M7_2b9Hfz2x=CMgOnQU9L3nU8QQeNOQ@mail.gmail.com> (raw)
In-Reply-To: <20210930110128.GQ18190@pengutronix.de>

You are right. I have the same problem, I will apply the solution you propose

On the other hand, it is possible to update only a part of the binary
(fip) with the fiptool update command. So, I think it is interesting
install the files (u-boot.dtb and u-boot-nodtb.bin) on
platform/images.

For example.
fiptool update --hw-config u-boot.dtb fip.bin

El jue, 30 sept 2021 a las 13:01, Michael Olbrich
(<m.olbrich@pengutronix.de>) escribió:
>
> On Sun, Sep 19, 2021 at 10:47:29AM +0200, avazquez.dev@gmail.com wrote:
> > From: Alejandro Vazquez <avazquez.dev@gmail.com>
> >
> > Adds support for copying u-boot.dtb and u-boot-nodtb.bin to the
> > platform image directory.
> > These files might be required by external tools
> > Ex: TF-A to generate FIP images.
>
> Hmmm, are you sure this works as expected? See this[1] discussion about
> that topic as well.
>
> Michael
>
> [1] https://lore.ptxdist.org/ptxdist/20210930105515.GP18190@pengutronix.de/
>
> > Signed-off-by: Alejandro Vazquez <avazquez.dev@gmail.com>
> > ---
> >  platforms/u-boot.in | 14 ++++++++++++++
> >  rules/u-boot.make   |  6 ++++++
> >  2 files changed, 20 insertions(+)
> >
> > diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> > index 4ddf3b3fb..3422f5018 100644
> > --- a/platforms/u-boot.in
> > +++ b/platforms/u-boot.in
> > @@ -247,5 +247,19 @@ config U_BOOT_INSTALL_U_BOOT_STM32
> >         platform image directory. Say yes if you are building for STM32MP1
> >         SOCs.
> >
> > +config U_BOOT_INSTALL_U_BOOT_NO_DTB
> > +     prompt "install u-boot-nodtb.bin"
> > +     bool
> > +     help
> > +       Installing the U-Boot binary without the device tree
> > +       into platform image directory.
> > +
> > +config U_BOOT_INSTALL_DTB
> > +     prompt "install u-boot.dtb"
> > +     bool
> > +     help
> > +       Installing the device tree binary into platform image directory.
> > +
> > +
> >  endif
> >
> > diff --git a/rules/u-boot.make b/rules/u-boot.make
> > index 38c32bf27..bda0445f1 100644
> > --- a/rules/u-boot.make
> > +++ b/rules/u-boot.make
> > @@ -177,6 +177,12 @@ endif
> >  ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_STM32
> >       @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot.stm32 $(IMAGEDIR)/u-boot.stm32
> >  endif
> > +ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_NO_DTB
> > +     @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot-nodtb.bin $(IMAGEDIR)/u-boot-nodtb.bin
> > +endif
> > +ifdef PTXCONF_U_BOOT_INSTALL_DTB
> > +     @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot.dtb $(IMAGEDIR)/u-boot.dtb
> > +endif
> >  ifndef PTXCONF_U_BOOT_ENV_IMAGE_NONE
> >       @install -v -D -m644 $(U_BOOT_BUILD_DIR)/u-boot-env.img \
> >               $(IMAGEDIR)/u-boot-env.img
> > --
> > 2.25.1
> >
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> >
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

      reply	other threads:[~2021-10-03 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19  8:47 avazquez.dev
2021-09-30 11:01 ` Michael Olbrich
2021-10-03 19:52   ` Alejandro Vazquez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOTEMUQ38fNGH+-gV01M7_2b9Hfz2x=CMgOnQU9L3nU8QQeNOQ@mail.gmail.com' \
    --to=avazquez.dev@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox