From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-bk0-f44.google.com ([209.85.214.44])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <linux.bohmer.net@gmail.com>) id 1S7Or0-0002gR-KF
	for ptxdist@pengutronix.de; Tue, 13 Mar 2012 11:21:19 +0100
Received: by bkuw5 with SMTP id w5so303665bku.31
	for <ptxdist@pengutronix.de>; Tue, 13 Mar 2012 03:21:13 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20120313095324.GG29221@pengutronix.de>
References: <1331587504-16721-1-git-send-email-linux@bohmer.net>
	<20120313095324.GG29221@pengutronix.de>
Date: Tue, 13 Mar 2012 11:21:12 +0100
Message-ID: <CANqCtQLXO-wDXM1ZHFy7=rLmP3E6wOkF9jVEoQXGnKXRKkyMHQ@mail.gmail.com>
From: Remy Bohmer <linux@bohmer.net>
Subject: Re: [ptxdist] [PATCH 1/5] [rt-tests] Use CFLAGS specified by
	ptxdist platformconfig
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi,

2012/3/13 Michael Olbrich <m.olbrich@pengutronix.de>:
>> +-CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include
>> ++CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include $(CXXFLAGS)
>
> This should be:
> CFLAGS = $(CPPFLAGS) -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include $(CFLAGS)
>
> CFLAGS is for C CXXFLAGS for C++ and CPPFLAGS in theory for the
> preprocessor and therefore often used to pass flags for both.
> And note the order.

Hmm, I knew that, not sure why I used CXXFLAGS...
Will fix it.

> And you should probably set:
>
> LIBS = $(LDFLAGS) -lrt -lpthread
>
> The flags should come first here.

Will check that.

Thanks.

Kind regards,

Remy

-- 
ptxdist mailing list
ptxdist@pengutronix.de