mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Remy Bohmer <linux@bohmer.net>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/5] [rt-tests] Use CFLAGS specified by ptxdist platformconfig
Date: Tue, 13 Mar 2012 11:21:12 +0100	[thread overview]
Message-ID: <CANqCtQLXO-wDXM1ZHFy7=rLmP3E6wOkF9jVEoQXGnKXRKkyMHQ@mail.gmail.com> (raw)
In-Reply-To: <20120313095324.GG29221@pengutronix.de>

Hi,

2012/3/13 Michael Olbrich <m.olbrich@pengutronix.de>:
>> +-CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include
>> ++CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include $(CXXFLAGS)
>
> This should be:
> CFLAGS = $(CPPFLAGS) -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include $(CFLAGS)
>
> CFLAGS is for C CXXFLAGS for C++ and CPPFLAGS in theory for the
> preprocessor and therefore often used to pass flags for both.
> And note the order.

Hmm, I knew that, not sure why I used CXXFLAGS...
Will fix it.

> And you should probably set:
>
> LIBS = $(LDFLAGS) -lrt -lpthread
>
> The flags should come first here.

Will check that.

Thanks.

Kind regards,

Remy

-- 
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2012-03-13 10:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 21:25 Remy Bohmer
2012-03-12 21:25 ` [ptxdist] [PATCH 2/5] [x86_64] Add some support for multilib detection in the toolchain Remy Bohmer
2012-03-13  9:56   ` Michael Olbrich
2012-03-13 10:23     ` Remy Bohmer
2012-03-12 21:25 ` [ptxdist] [PATCH 3/5] [busybox] Pass extra platform CFLAGS to busybox make Remy Bohmer
2012-03-13  9:59   ` Michael Olbrich
2012-03-13 10:26     ` Remy Bohmer
2012-03-13 12:46     ` Remy Bohmer
2012-03-13 13:06       ` Michael Olbrich
2012-03-13 21:31         ` Remy Bohmer
2012-03-12 21:25 ` [ptxdist] [PATCH 4/5] [x86_64, libc] on multilib do not put all dynamic linkers in /lib Remy Bohmer
2012-03-13 10:07   ` Michael Olbrich
2012-03-13 10:28     ` Remy Bohmer
2012-03-13 10:34     ` Remy Bohmer
2012-03-13 10:58       ` Michael Olbrich
2012-03-12 21:25 ` [ptxdist] [PATCH 5/5] [x86_64, libc] Link /usr/lib/libdl.so is not needed and wrong on x86_64 Remy Bohmer
2012-03-13  9:53 ` [ptxdist] [PATCH 1/5] [rt-tests] Use CFLAGS specified by ptxdist platformconfig Michael Olbrich
2012-03-13 10:21   ` Remy Bohmer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANqCtQLXO-wDXM1ZHFy7=rLmP3E6wOkF9jVEoQXGnKXRKkyMHQ@mail.gmail.com' \
    --to=linux@bohmer.net \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox