From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-bk0-f44.google.com ([209.85.214.44])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <linux.bohmer.net@gmail.com>) id 1SA50Q-0000Zq-6F
	for ptxdist@pengutronix.de; Tue, 20 Mar 2012 20:46:25 +0100
Received: by bkuw5 with SMTP id w5so386646bku.31
	for <ptxdist@pengutronix.de>; Tue, 20 Mar 2012 12:46:00 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1332272207-80692-1-git-send-email-bernhard@bwalle.de>
References: <201203202028.39620.jbe@pengutronix.de>
	<1332272207-80692-1-git-send-email-bernhard@bwalle.de>
Date: Tue, 20 Mar 2012 20:46:00 +0100
Message-ID: <CANqCtQKhD5DgGi+O2z=X2mTi9QOULr-fk9E9zfHZyDz-H8dSEw@mail.gmail.com>
From: Remy Bohmer <linux@bohmer.net>
Subject: Re: [ptxdist] [PATCH] flashbench: Fix error when flashbench is not
	selected
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi,

2012/3/20 Bernhard Walle <bernhard@bwalle.de>:
> When flashbench is not selected in "ptxdist menuconfig", then
> $(PTXCONF_FLASHBENCH_MAX_BUFSIZE) is undefined. In that case, the expr
> call fails.
>
> Fix the problem by delaying the evaluation of FLASHBENCH_MAKE_OPT until
> it's really needed, i.e. when flashbench has been selected.
>
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
> =A0rules/flashbench.make | =A0 =A02 +-
> =A01 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rules/flashbench.make b/rules/flashbench.make
> index fcb669e..0ef52d1 100644
> --- a/rules/flashbench.make
> +++ b/rules/flashbench.make
> @@ -31,7 +31,7 @@ FLASHBENCH_LICENSE =A0 =A0:=3D GPL v2
>
> =A0FLASHBENCH_CONF_TOOL =A0 :=3D NO
> =A0FLASHBENCH_MAKE_ENV =A0 =A0:=3D $(CROSS_ENV)
> -FLASHBENCH_MAKE_OPT =A0 =A0:=3D CC=3D$(CROSS_CC) \
> +FLASHBENCH_MAKE_OPT =A0 =A0=3D CC=3D$(CROSS_CC) \
> =A0 =A0 =A0 =A0EXTRA_CFLAGS=3D-DMAX_BUFSIZE=3D$(shell expr 1024 \* 1024 \=
* $(PTXCONF_FLASHBENCH_MAX_BUFSIZE))

Acked-by: Remy Bohmer <linux@bohmer.net>

Kind regards,

Remy

-- =

ptxdist mailing list
ptxdist@pengutronix.de