From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bk0-f44.google.com ([209.85.214.44]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1SBVi7-0001aQ-ER for ptxdist@pengutronix.de; Sat, 24 Mar 2012 19:29:08 +0100 Received: by bkuw5 with SMTP id w5so3691015bku.31 for ; Sat, 24 Mar 2012 11:29:01 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20120323075331.GB20731@pengutronix.de> References: <1332191692-20833-1-git-send-email-linux@bohmer.net> <20120323075331.GB20731@pengutronix.de> Date: Sat, 24 Mar 2012 19:29:01 +0100 Message-ID: From: Remy Bohmer Subject: Re: [ptxdist] [PATCH 1/9 v2] [x86_64] Add x86_64 architecture strings. Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Hi, 2012/3/23 Michael Olbrich : > Hi, > > I've seen the whole series, but I'm rather busy, and this requires a bit > more thinking. So it may take a while before we get everything in. > > On Mon, Mar 19, 2012 at 10:14:44PM +0100, Remy Bohmer wrote: >> The ARCH_X86_64 architecture is added as subtype of ARCH_X86 since it >> basically is the same architecture, and a mix of both architectures >> will be required to allow multilib support in a later commit. >> >> Signed-off-by: Remy Bohmer >> --- >> =A0v2: no changes since v1 >> >> =A0platforms/architecture.in | =A0 15 +++++++++++++-- >> =A01 files changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/platforms/architecture.in b/platforms/architecture.in >> index ed36e8a..f00108e 100644 >> --- a/platforms/architecture.in >> +++ b/platforms/architecture.in >> @@ -181,6 +181,16 @@ choice >> >> =A0endchoice >> >> +if ARCH_X86 >> +# >> +# 32/64 bits platform >> +# >> +config ARCH_X86_64 >> + =A0 =A0 bool "64 bit architecture" >> + =A0 =A0 help >> + =A0 =A0 =A0 Select this option if you build for a 64 bit architecture. >> + >> +endif > > Have you considered adding ARCH_X86_32 as well (in a switch)? I think some > if our current "ifdef ARCH_X86" are really for 32bit only, so an option > would probably be useful. I considered that but thought to look it like this: Assume the platform is 32 bit, unless specified otherwise. But maybe I have to look it at it more carefully. I drop it from the series, and will repost this patch later. First, finalize the rest of the series first. Kind regards, Remy -- = ptxdist mailing list ptxdist@pengutronix.de