From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-bk0-f44.google.com ([209.85.214.44])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <linux.bohmer.net@gmail.com>) id 1S9hva-0005Pp-65
	for ptxdist@pengutronix.de; Mon, 19 Mar 2012 20:07:53 +0100
Received: by bkuw5 with SMTP id w5so5401732bku.31
	for <ptxdist@pengutronix.de>; Mon, 19 Mar 2012 12:07:26 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20120319161729.GG20481@pengutronix.de>
References: <1332097818-23592-1-git-send-email-linux@bohmer.net>
	<1332097818-23592-5-git-send-email-linux@bohmer.net>
	<20120319161729.GG20481@pengutronix.de>
Date: Mon, 19 Mar 2012 20:07:26 +0100
Message-ID: <CANqCtQ+xE_ib+WT_B=A=L+dUX0B_sW-v99X_UkdoYJ12xQtEUA@mail.gmail.com>
From: Remy Bohmer <linux@bohmer.net>
Subject: Re: [ptxdist] [PATCH 4/9] [x86_64,
 multilib] Make packages install their libraries at the right place
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi,

2012/3/19 Michael Olbrich <m.olbrich@pengutronix.de>:
>> +# Outputs 'lib' or 'lib64', derived from the ld-linux.so.2 from the com=
piler toolchain
>> +CROSS_LIB_DIR =A0 =A0 =A0 =A0:=3D $(shell =A0 \
>> + =A0 =A0 dl=3D"$$(echo 'int main(void){return 0;}' | \
>> + =A0 =A0 ${CROSS_CC} ${CROSS_CPPFLAGS} ${CROSS_CFLAGS} -x c -o /dev/nul=
l -v - 2>&1 | \
>> + =A0 =A0 sed -n -e 's/.* -dynamic-linker \([^ ]*\).*/\1/p')"; \
>> + =A0 =A0 lib_dir=3D"$${dl%%/ld-linux*}"; \
>> + =A0 =A0 echo "$${lib_dir\#/}" \
>> +)
>
> This is the same as ptxd_get_lib_dir, right? This function should be
> defined here:

This is indeed the same function, but for some reason the
ptxd_get_lib_dir was not available.
I will look at it again.

>> - =A0 =A0local file=3D"$(for dir in "${pkg_pkg_dir}/"{,usr/}lib; do
>> + =A0 =A0local file=3D"$(for dir in "${pkg_pkg_dir}/"{,usr/}lib{,64}; do
>
> I don't like the explicit lib64 here. Next we'll get some debian like
> multilib toolchain and it's lib/x86_64-linux-gnu oor so. Can't we get that
> from ptxd_get_lib_dir?

I think you are right and we can get it from ptxd_get_lib_dir, did not
thought about that before. Good idea!

Kind regards,

Remy

-- =

ptxdist mailing list
ptxdist@pengutronix.de