From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-bk0-f44.google.com ([209.85.214.44])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <linux.bohmer.net@gmail.com>) id 1S7mXo-000073-I3
	for ptxdist@pengutronix.de; Wed, 14 Mar 2012 12:39:05 +0100
Received: by bkuw5 with SMTP id w5so1408969bku.31
	for <ptxdist@pengutronix.de>; Wed, 14 Mar 2012 04:38:58 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20120314104556.GF20481@pengutronix.de>
References: <1331674338-1757-1-git-send-email-linux@bohmer.net>
	<1331674338-1757-3-git-send-email-linux@bohmer.net>
	<20120314104251.GE20481@pengutronix.de>
	<20120314104556.GF20481@pengutronix.de>
Date: Wed, 14 Mar 2012 12:38:58 +0100
Message-ID: <CANqCtQ+nwPB92L8ogUj4GjycyhtU1aL7EjqmMX+Wb7mRivUicw@mail.gmail.com>
From: Remy Bohmer <linux@bohmer.net>
Subject: Re: [ptxdist] [PATCH 3/5 v2] [busybox] Pass extra platform CFLAGS
 to busybox make
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi,

2012/3/14 Michael Olbrich <m.olbrich@pengutronix.de>:
>>
>> Indent with on <tab> everywhere.

OK

>> > +
>> > +BUSYBOX_MAKE_ENV :=3D \
>> > + =A0 =A0 =A0 $(CROSS_ENV) \
>> > + =A0 =A0 =A0 CFLAGS=3D"$(CROSS_CFLAGS) -I$(KERNEL_HEADERS_INCLUDE_DIR=
)"
>> > + =A0 =A0 =A0 SKIP_STRIP=3Dy
>>
>> Looks like SKIP_STRIP=3Dy must be in BUSYBOX_MAKE_OPT, or it's not used.
>
> No wait, you're just missing '\' at the end of the previous line.

Fun :-)
I just copied your proposal and tested if it did what it needed to do...

I will fix it and repost a new patch version.

Thanks.

Kind regards,

Remy

-- =

ptxdist mailing list
ptxdist@pengutronix.de