From: Remy Bohmer <linux@bohmer.net>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 3/5 v2] [busybox] Pass extra platform CFLAGS to busybox make
Date: Wed, 14 Mar 2012 12:38:58 +0100 [thread overview]
Message-ID: <CANqCtQ+nwPB92L8ogUj4GjycyhtU1aL7EjqmMX+Wb7mRivUicw@mail.gmail.com> (raw)
In-Reply-To: <20120314104556.GF20481@pengutronix.de>
Hi,
2012/3/14 Michael Olbrich <m.olbrich@pengutronix.de>:
>>
>> Indent with on <tab> everywhere.
OK
>> > +
>> > +BUSYBOX_MAKE_ENV := \
>> > + $(CROSS_ENV) \
>> > + CFLAGS="$(CROSS_CFLAGS) -I$(KERNEL_HEADERS_INCLUDE_DIR)"
>> > + SKIP_STRIP=y
>>
>> Looks like SKIP_STRIP=y must be in BUSYBOX_MAKE_OPT, or it's not used.
>
> No wait, you're just missing '\' at the end of the previous line.
Fun :-)
I just copied your proposal and tested if it did what it needed to do...
I will fix it and repost a new patch version.
Thanks.
Kind regards,
Remy
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-03-14 11:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 21:32 [ptxdist] [PATCH 1/5 v2] [rt-tests] Use CFLAGS specified by ptxdist platformconfig Remy Bohmer
2012-03-13 21:32 ` [ptxdist] [PATCH 2/5 v2] [x86_64] Add some support for multilib detection in the toolchain Remy Bohmer
2012-03-13 21:32 ` [ptxdist] [PATCH 3/5 v2] [busybox] Pass extra platform CFLAGS to busybox make Remy Bohmer
2012-03-14 10:42 ` Michael Olbrich
2012-03-14 10:45 ` Michael Olbrich
2012-03-14 11:38 ` Remy Bohmer [this message]
2012-03-13 21:32 ` [ptxdist] [PATCH 4/5 v2] [x86_64, glibc] on multilib do not put all dynamic linkers in /lib Remy Bohmer
2012-03-13 21:32 ` [ptxdist] [PATCH 5/5 v2] [x86_64, glibc] Link /usr/lib/libdl.so is not needed and wrong on x86_64 Remy Bohmer
2012-03-15 10:31 ` [ptxdist] [PATCH 1/5 v2] [rt-tests] Use CFLAGS specified by ptxdist platformconfig Michael Olbrich
2012-03-15 11:52 ` Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANqCtQ+nwPB92L8ogUj4GjycyhtU1aL7EjqmMX+Wb7mRivUicw@mail.gmail.com \
--to=linux@bohmer.net \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox