From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1epEDc-0003ZM-6K for ptxdist@pengutronix.de; Fri, 23 Feb 2018 15:21:00 +0100 Received: by mail-qk0-x236.google.com with SMTP id v124so10889951qkh.11 for ; Fri, 23 Feb 2018 06:20:59 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180222221028.v6f7fyrd3mrkqh7k@pengutronix.de> References: <20180222203409.teh2ugnegphvp2dt@pengutronix.de> <20180222221028.v6f7fyrd3mrkqh7k@pengutronix.de> From: Jon Ringle Date: Fri, 23 Feb 2018 09:20:57 -0500 Message-ID: Subject: Re: [ptxdist] gdb python support List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============1016288642==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de --===============1016288642== Content-Type: multipart/alternative; boundary="001a1147e2c87de0180565e1de93" --001a1147e2c87de0180565e1de93 Content-Type: text/plain; charset="UTF-8" > > > > > 4) rules/cross-gdb.make has the following, but I do not have > > > > CROSS_GDB_WITHOUT_PYTHON set at all in my environment: > > > > > > Are you using build_all_v2.mk or build_one.sh? Then > > > CROSS_GDB_WITHOUT_PYTHON is set to 'y' by default. > > > > > > > > Ok. I see that there now. It would be nice if this default was > consistent. > > Reading the `cross-gdb.make` it appears that the default is with python, > > but the `build_all_v2.mk` has the default the opposite. Can we pick a > > default and stick to it? > > It's just a hack from a long time ago when the dependency handling was > broken. I just never bothered to change this. Patches are welcome. > > I'd be happy to create a patch. Which way is preferable? 1) default --without-python and require an "opt-in" for --with-python=python3 or 2) default --with-python=python3 and require an "opt-out" for --without-python If 1) is preferred, is it ok to rename CROSS_GDB_WITHOUT_PYTHON => CROSS_GDB_WITH_PYTHON? The reason is that we'd want the non-existence of the env variable to be applied as the default -Jon --001a1147e2c87de0180565e1de93 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> > > 4) rules/cross-g= db.make has the following, but I do not have
> > > CROSS_GDB_WITHOUT_PYTHON set at all in my environment:
> >
> > Are you using build_all_v2.mk or build_one.sh? Then
> > CROSS_GDB_WITHOUT_PYTHON is set to 'y' by default.
> >
> >
> Ok. I see that there now. It would be nice if this default was consist= ent.
> Reading the `cross-gdb.make` it appears that the default is with pytho= n,
> but the `build_all_v2.mk` has the default the opposite. Can we pick = a
> default and stick to it?

It's just a hack from a long time ago when the dependency handli= ng was
broken. I just never bothered to change this. Patches are welcome.


I'd be happy to c= reate a patch. Which way is preferable?
1) default --without-python and= require an "opt-in" for --with-python=3Dpython3
or
2) d= efault --with-python=3Dpython3 and require an "opt-out" for --wit= hout-python

If 1) is preferred, is it ok to rename CROSS_GDB_W= ITHOUT_PYTHON =3D> CROSS_GDB_WITH_PYTHON?
The reason is that we'= d want the non-existence of the env variable to be applied as the default

-Jon

--001a1147e2c87de0180565e1de93-- --===============1016288642== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============1016288642==--