Re: [ptxdist] [PATCH 1/3] host-faketime: new package

[Jon Ringle <jon@ringle.org>]

On Thu, Oct 11, 2018 at 10:43 AM Roland Hieber <r.hieber@pengutronix.de> wrote:
>
> Hmmm, we had a similar patch in August that added libfaketime as a
> runtime dependency to PTXdist in order to detect changes to packages'
> patch series:
>
> https://www.mail-archive.com/ptxdist@pengutronix.de/msg13198.html
>
> If we can be sure that faketime is present at run time, we could leave
> it out as a host package (or maybe only need a host-system-faketime
> package instead).
>
> Jon (or mol?), I think the patches from that series were never applied,
> but in light of recent development I don't know if they are still
> needed. In any case, does it make more sense to have faketime as a host
> system dependency available at PTXdist startup, or is a host-* package
> in PTXdist as proposed by Florian here sufficient?


mol had suggested the following as an alternative to my patch, but I
haven't gotten around to trying it:
> I think it should be possible to provide the correct timestamps with
> GIT_AUTHOR_DATE and/or GIT_COMMITTER_DATE or something like that.

In any case, what I proposed was independent of having a host faketime.

>
>  - Roland
>
> On Thu, Oct 11, 2018 at 02:19:15PM +0000, Baeuerle, Florian wrote:
> > Signed-off-by: Florian Bäuerle <florian.baeuerle@allegion.com>
> > ---
> >  rules/host-faketime.in   | 10 +++++++++
> >  rules/host-faketime.make | 47 ++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 57 insertions(+)
> >  create mode 100644 rules/host-faketime.in
> >  create mode 100644 rules/host-faketime.make
> >
> > diff --git a/rules/host-faketime.in b/rules/host-faketime.in
> > new file mode 100644
> > index 000000000..1a2e7ae19
> > --- /dev/null
> > +++ b/rules/host-faketime.in
> > @@ -0,0 +1,10 @@
> > +## SECTION=hosttools_noprompt
> > +## SECTION=hosttools_platform
> > +
> > +config HOST_FAKETIME
> > +     tristate
> > +     default ALLYES
> > +     help
> > +       libfaketime intercepts various system calls that programs use to
> > +       retrieve the current date and time. It then reports modified (faked)
> > +       dates and times to these programs.
> > diff --git a/rules/host-faketime.make b/rules/host-faketime.make
> > new file mode 100644
> > index 000000000..462854eb9
> > --- /dev/null
> > +++ b/rules/host-faketime.make
> > @@ -0,0 +1,47 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2018 by Florian Bäuerle <florian.baeuerle@allegion.com>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +HOST_PACKAGES-$(PTXCONF_HOST_FAKETIME) += host-faketime
> > +
> > +#
> > +# Paths and names
> > +#
> > +HOST_FAKETIME_VERSION        = $(LIBFAKETIME_VERSION)
> > +HOST_FAKETIME_MD5    = $(LIBFAKETIME_MD5)
> > +HOST_FAKETIME                = $(LIBFAKETIME)
> > +HOST_FAKETIME_SUFFIX = $(LIBFAKETIME_SUFFIX)
> > +HOST_FAKETIME_URL    = $(LIBFAKETIME_URL)
> > +HOST_FAKETIME_SOURCE = $(LIBFAKETIME_SOURCE)
> > +HOST_FAKETIME_LICENSE        = $(LIBFAKETIME_LICENSE)
> > +HOST_FAKETIME_DIR    = $(HOST_BUILDDIR)/$(HOST_FAKETIME)

I would suggest that it should be called host-libfaketime, which
should then allow much of the boilerplate code above to be removed

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de