Re: [ptxdist] [PATCH] Detect changes in package patch series

[Jon Ringle <jon@ringle.org>]

On Fri, Aug 3, 2018 at 3:36 AM Jon Ringle <jon@ringle.org> wrote:
>
> On Fri, Aug 3, 2018 at 3:19 AM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > Hello Jon,
> >
> > On Thu, Aug 02, 2018 at 09:49:59PM -0400, jon@ringle.org wrote:
> > > diff --git a/scripts/git-ptx-patches b/scripts/git-ptx-patches
> > > index f2568f9..738a4ac 100755
> > > --- a/scripts/git-ptx-patches
> > > +++ b/scripts/git-ptx-patches
> > > @@ -2,11 +2,33 @@
> > >
> > >  PTX_PATCHES_HEADER="# generated by git-ptx-patches"
> > >
> > > -function _md5sum() {
> > > -     local sum=$(md5sum)
> > > +function _sha1sum() {
> > > +     local sum=$(git rev-parse HEAD)
> > >       echo "# $sum git-ptx-patches magic"
> > >  }
> > >
> > > +update_series_md5() {
> > > +     local makefile="$(readlink -f .ptxdist/rule.make)"
> > > +     source .ptxdist/rule.env
> > > +     set -- $(md5sum .ptxdist/series)
> > > +     local md5="${1}"
> >
> > Is this better than:
> >
> >         local md5="$(md5sum .ptxdist/series)"
> >
> > ?
>
> I was modeling the pattern found in `ptxd_make_world_update_md5()`
> found in scripts/lib/ptxd_make_world_check_src.sh:
>   | ptxd_make_world_update_md5() {
>   |     local PKG="$(ptxd_name_to_NAME "${pkg_label}")"
>   |     set -- $(md5sum "${pkg_src}")
>   |     local md5="${1}"
>
> I can change it to the way you are suggesting, though

local sha256="$(sha256sum .ptxdist/series)"
does not work, because this assigns to sha256 the value
"36169a70924328a204978a3bee7100efa526059b41a11572bdf210048109a808
.ptxdist/series"

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de