From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: MIME-Version: 1.0 References: <1533311096-14315-1-git-send-email-jon@ringle.org> <20180808095028.5icy6qduj53e6av3@pengutronix.de> In-Reply-To: <20180808095028.5icy6qduj53e6av3@pengutronix.de> From: Jon Ringle Date: Wed, 8 Aug 2018 06:58:55 -0400 Message-ID: Subject: Re: [ptxdist] [PATCH v4 1/2] Add libfaketime as a core component of ptxdist for patchin support List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0473786001==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.com, Jon Ringle --===============0473786001== Content-Type: multipart/alternative; boundary="0000000000003c27ef0572ea66f7" --0000000000003c27ef0572ea66f7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 8, 2018 at 5:50 AM Roland Hieber wrote: > On Fri, Aug 03, 2018 at 11:44:55AM -0400, jon@ringle.org wrote: > > From: Jon Ringle > > > > libfaketime will be used during patchin so that committer timestamps > always > > have a fixed value and therefore making the ${PKG}_SERIES_SHA256 value > > repeatable > > > > The minimal set of source files was picked out of libfaketime-0.9.7 > > > > Signed-off-by: Jon Ringle > > --- > > Makefile.in | 14 +- > > scripts/libfaketime/Makefile | 118 ++ > > scripts/libfaketime/faketime.c | 385 ++++++ > > scripts/libfaketime/faketime_common.h | 61 + > > scripts/libfaketime/libfaketime.c | 2410 > +++++++++++++++++++++++++++++++++ > > scripts/libfaketime/libfaketime.map | 10 + > > scripts/libfaketime/time_ops.h | 104 ++ > > Uh. Does it really make more sense to vendor libfaketime instead of > using the package from the host system, like we do it with python, bash, > etc.? > The reason that this is needed as a core component of ptxdist rather than just being built as a host package is that patchin step uses libfaketime and therefore is potentially needed before even a single package is ever built. What would happen if we just used a host-libfaketime package and someone adds a patch series for libfaketime? (In fact, I actually do have such a patch series locally that I will be sending to the ptxdist ml later). This is a chicken vs egg problem that is resolved by making libfaketime an integral part of ptxdist. The ptxdist usage of libfaketime in the patchin step does not need a patched version of libfaketime (it just needs to set an absolute date time and the libfaketime code I have here does that). It doesn=E2=80=99t need new configuration features or bug fixes= for fixing the time manipulation via some specific system call. -Jon --0000000000003c27ef0572ea66f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed,= Aug 8, 2018 at 5:50 AM Roland Hieber <r.hieber@pengutronix.de> wrote:
On Fri, Aug 03, 2018 at 11:44:55AM -0400, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> libfaketime will be used during patchin so that committer timestamps a= lways
> have a fixed value and therefore making the ${PKG}_SERIES_SHA256 value=
> repeatable
>
> The minimal set of source files was picked out of libfaketime-0.9.7 >
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
>=C2=A0 Makefile.in=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A014 +-
>=C2=A0 scripts/libfaketime/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 118 ++
>=C2=A0 scripts/libfaketime/faketime.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 385 ++++++
>=C2=A0 scripts/libfaketime/faketime_common.h |=C2=A0 =C2=A061 +
>=C2=A0 scripts/libfaketime/libfaketime.c=C2=A0 =C2=A0 =C2=A0| 2410 ++++= +++++++++++++++++++++++++++++
>=C2=A0 scripts/libfaketime/libfaketime.map=C2=A0 =C2=A0|=C2=A0 =C2=A010= +
>=C2=A0 scripts/libfaketime/time_ops.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 104 ++

Uh. Does it really make more sense to vendor libfaketime instead of
using the package from the host system, like we do it with python, bash, etc.?

The reason that = this is needed as a core component of ptxdist rather than just being built = as a host package is that patchin step uses libfaketime and therefore is po= tentially needed before even a single package is ever built. What would hap= pen if we just used a host-libfaketime package and someone adds a patch ser= ies for libfaketime? (In fact, I actually do have such a patch series local= ly that I will be sending to the ptxdist ml later). This is a chicken vs eg= g problem that is resolved by making libfaketime an integral part of ptxdis= t. The ptxdist usage of libfaketime in the patchin step does not need a pat= ched version of libfaketime (it just needs to set an absolute date time and= the libfaketime code I have here does that). It doesn=E2=80=99t need new c= onfiguration features or bug fixes for fixing the time manipulation via som= e specific system call.

= -Jon
--0000000000003c27ef0572ea66f7-- --===============0473786001== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============0473786001==--