From: Jon Ringle <jon@ringle.org>
To: ptxdist@pengutronix.de
Cc: ptxdist@pengutronix.com, Jon Ringle <jringle@gridpoint.com>
Subject: Re: [ptxdist] [PATCH v4 1/2] Add libfaketime as a core component of ptxdist for patchin support
Date: Wed, 8 Aug 2018 06:58:55 -0400 [thread overview]
Message-ID: <CAMwGMjyOZi2_x3vj7USWB7DaXPm+gbtGJujBhjfQR6aXyS-Jcw@mail.gmail.com> (raw)
In-Reply-To: <20180808095028.5icy6qduj53e6av3@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1980 bytes --]
On Wed, Aug 8, 2018 at 5:50 AM Roland Hieber <r.hieber@pengutronix.de>
wrote:
> On Fri, Aug 03, 2018 at 11:44:55AM -0400, jon@ringle.org wrote:
> > From: Jon Ringle <jringle@gridpoint.com>
> >
> > libfaketime will be used during patchin so that committer timestamps
> always
> > have a fixed value and therefore making the ${PKG}_SERIES_SHA256 value
> > repeatable
> >
> > The minimal set of source files was picked out of libfaketime-0.9.7
> >
> > Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> > ---
> > Makefile.in | 14 +-
> > scripts/libfaketime/Makefile | 118 ++
> > scripts/libfaketime/faketime.c | 385 ++++++
> > scripts/libfaketime/faketime_common.h | 61 +
> > scripts/libfaketime/libfaketime.c | 2410
> +++++++++++++++++++++++++++++++++
> > scripts/libfaketime/libfaketime.map | 10 +
> > scripts/libfaketime/time_ops.h | 104 ++
>
> Uh. Does it really make more sense to vendor libfaketime instead of
> using the package from the host system, like we do it with python, bash,
> etc.?
>
The reason that this is needed as a core component of ptxdist rather than
just being built as a host package is that patchin step uses libfaketime
and therefore is potentially needed before even a single package is ever
built. What would happen if we just used a host-libfaketime package and
someone adds a patch series for libfaketime? (In fact, I actually do have
such a patch series locally that I will be sending to the ptxdist ml
later). This is a chicken vs egg problem that is resolved by making
libfaketime an integral part of ptxdist. The ptxdist usage of libfaketime
in the patchin step does not need a patched version of libfaketime (it just
needs to set an absolute date time and the libfaketime code I have here
does that). It doesn’t need new configuration features or bug fixes for
fixing the time manipulation via some specific system call.
-Jon
[-- Attachment #1.2: Type: text/html, Size: 2626 bytes --]
[-- Attachment #2: Type: text/plain, Size: 91 bytes --]
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-08-08 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 15:44 jon
2018-08-03 15:44 ` [ptxdist] [PATCH v4 2/2] Detect changes in package patch series jon
2018-08-08 9:50 ` [ptxdist] [PATCH v4 1/2] Add libfaketime as a core component of ptxdist for patchin support Roland Hieber
2018-08-08 10:58 ` Jon Ringle [this message]
2018-08-08 19:27 ` Jon Ringle
2018-08-27 16:27 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMwGMjyOZi2_x3vj7USWB7DaXPm+gbtGJujBhjfQR6aXyS-Jcw@mail.gmail.com \
--to=jon@ringle.org \
--cc=jringle@gridpoint.com \
--cc=ptxdist@pengutronix.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox