From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf1-f66.google.com ([209.85.167.66]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1flVyS-0005VD-41 for ptxdist@pengutronix.de; Fri, 03 Aug 2018 11:02:17 +0200 Received: by mail-lf1-f66.google.com with SMTP id v22-v6so3530855lfe.8 for ; Fri, 03 Aug 2018 02:02:15 -0700 (PDT) MIME-Version: 1.0 References: <1533285716-7652-1-git-send-email-jon@ringle.org> <20180803085058.mot6lmjo3t276sfi@pengutronix.de> In-Reply-To: <20180803085058.mot6lmjo3t276sfi@pengutronix.de> From: Jon Ringle Date: Fri, 3 Aug 2018 05:02:03 -0400 Message-ID: Subject: Re: [ptxdist] [PATCH v3] Detect changes in package patch series List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============1798214011==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de --===============1798214011== Content-Type: multipart/alternative; boundary="000000000000155b3d0572842f98" --000000000000155b3d0572842f98 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 3, 2018 at 4:51 AM Uwe Kleine-K=C3=B6nig < u.kleine-koenig@pengutronix.de> wrote: > On Fri, Aug 03, 2018 at 04:41:56AM -0400, jon@ringle.org wrote: > > From: Jon Ringle > > > > For a long time it has bothered me that if a package's patches were > changed > > ptxdist would not detect this change and I would often have old version= s > of > > *-dev.tar.gz packages that got used because the packages patches were > > updated. > > > > This commit solves this problem. > > > > Here's how it works: > > 1) In the package rule makefile add `${PKG}_SERIES_SHA256 :=3D` > > 2) extract the package and from the packages src dir do `git ptx-patche= s` > > This will populate the rule makefile _SERIES_SHA256 value > > 3) Anytime you make a patch change to a package and do `git ptx-patches= ` > > the series file gets updated with the `git rev-parse HEAD` value whi= ch > > causes the series file to have a new sha256 value and therefore a ne= w > > value gets populated in the rule makefile, which then causes the > package > > to be rebuilt and the *-dev.tar.gz package will have a different > cfghash > > in the filename > > I didn't test, but if the value of $(git rev-parse HEAD) is relevant: > Are you aware that this isn't reproducible, i.e. it changes by > > ptxdist clean pukyxml > ptxdist extract --git pukyxml > > ? > under what circumstances would you get a different value for the `git rev-parse HEAD` if the package version, series and patches being applied has not changed? -Jon --000000000000155b3d0572842f98 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri,= Aug 3, 2018 at 4:51 AM Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de> wrote:
<= /div>
On Fri, Aug 03, 2018 at 04:41:56AM -040= 0, jon@ringle.org w= rote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> For a long time it has bothered me that if a package's patches wer= e changed
> ptxdist would not detect this change and I would often have old versio= ns of
> *-dev.tar.gz packages that got used because the packages patches were<= br> > updated.
>
> This commit solves this problem.
>
> Here's how it works:
> 1) In the package rule makefile add `${PKG}_SERIES_SHA256 :=3D`
> 2) extract the package and from the packages src dir do `git ptx-patch= es`
>=C2=A0 =C2=A0 This will populate the rule makefile _SERIES_SHA256 value=
> 3) Anytime you make a patch change to a package and do `git ptx-patche= s`
>=C2=A0 =C2=A0 the series file gets updated with the `git rev-parse HEAD= ` value which
>=C2=A0 =C2=A0 causes the series file to have a new sha256 value and the= refore a new
>=C2=A0 =C2=A0 value gets populated in the rule makefile, which then cau= ses the package
>=C2=A0 =C2=A0 to be rebuilt and the *-dev.tar.gz package will have a di= fferent cfghash
>=C2=A0 =C2=A0 in the filename

I didn't test, but if the value of $(git rev-parse HEAD) is relevant: Are you aware that this isn't reproducible, i.e. it changes by

=C2=A0 =C2=A0 =C2=A0 =C2=A0 ptxdist clean pukyxml
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ptxdist extract --git pukyxml

?

under what circu= mstances would you get a different value for the `git rev-parse HEAD` if th= e package version, series and patches being applied has not changed?
<= div dir=3D"auto">
-Jon
--000000000000155b3d0572842f98-- --===============1798214011== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============1798214011==--