From: Jon Ringle <jon@ringle.org>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v3] Detect changes in package patch series
Date: Fri, 3 Aug 2018 05:02:03 -0400 [thread overview]
Message-ID: <CAMwGMjy82-3dW4MmYAwMgY0oXkyKbufo8zzQHHpwJ-kH5Q7KMQ@mail.gmail.com> (raw)
In-Reply-To: <20180803085058.mot6lmjo3t276sfi@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1585 bytes --]
On Fri, Aug 3, 2018 at 4:51 AM Uwe Kleine-König <
u.kleine-koenig@pengutronix.de> wrote:
> On Fri, Aug 03, 2018 at 04:41:56AM -0400, jon@ringle.org wrote:
> > From: Jon Ringle <jringle@gridpoint.com>
> >
> > For a long time it has bothered me that if a package's patches were
> changed
> > ptxdist would not detect this change and I would often have old versions
> of
> > *-dev.tar.gz packages that got used because the packages patches were
> > updated.
> >
> > This commit solves this problem.
> >
> > Here's how it works:
> > 1) In the package rule makefile add `${PKG}_SERIES_SHA256 :=`
> > 2) extract the package and from the packages src dir do `git ptx-patches`
> > This will populate the rule makefile _SERIES_SHA256 value
> > 3) Anytime you make a patch change to a package and do `git ptx-patches`
> > the series file gets updated with the `git rev-parse HEAD` value which
> > causes the series file to have a new sha256 value and therefore a new
> > value gets populated in the rule makefile, which then causes the
> package
> > to be rebuilt and the *-dev.tar.gz package will have a different
> cfghash
> > in the filename
>
> I didn't test, but if the value of $(git rev-parse HEAD) is relevant:
> Are you aware that this isn't reproducible, i.e. it changes by
>
> ptxdist clean pukyxml
> ptxdist extract --git pukyxml
>
> ?
>
under what circumstances would you get a different value for the `git
rev-parse HEAD` if the package version, series and patches being applied
has not changed?
-Jon
[-- Attachment #1.2: Type: text/html, Size: 2183 bytes --]
[-- Attachment #2: Type: text/plain, Size: 91 bytes --]
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-08-03 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 8:41 jon
2018-08-03 8:50 ` Uwe Kleine-König
2018-08-03 9:02 ` Jon Ringle [this message]
2018-08-03 10:01 ` Uwe Kleine-König
2018-08-27 15:59 ` Michael Olbrich
2018-08-27 17:13 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMwGMjy82-3dW4MmYAwMgY0oXkyKbufo8zzQHHpwJ-kH5Q7KMQ@mail.gmail.com \
--to=jon@ringle.org \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox