From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1W6idh-0004JD-Uk for ptxdist@pengutronix.de; Fri, 24 Jan 2014 16:26:09 +0100 Received: by mail-lb0-f176.google.com with SMTP id w7so2648609lbi.35 for ; Fri, 24 Jan 2014 07:25:44 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20140124150315.GE7704@pengutronix.de> References: <20140121095642.GK29805@pengutronix.de> <20140123161053.GB11312@pengutronix.de> <20140124091603.GA7704@pengutronix.de> <20140124150315.GE7704@pengutronix.de> Date: Fri, 24 Jan 2014 10:25:43 -0500 Message-ID: From: Jon Ringle Subject: Re: [ptxdist] Add patch series to ${PTXDIST_TEMPDIR}/pkghash-* Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Fri, Jan 24, 2014 at 10:03 AM, Michael Olbrich wrote: > On Fri, Jan 24, 2014 at 08:45:42AM -0500, Jon Ringle wrote: >> On Fri, Jan 24, 2014 at 4:16 AM, Michael Olbrich >> wrote: >> > On Thu, Jan 23, 2014 at 12:30:11PM -0500, Jon Ringle wrote: >> >> On Thu, Jan 23, 2014 at 11:10 AM, Michael Olbrich >> >> wrote: >> >> > On Tue, Jan 21, 2014 at 09:02:49AM -0500, Jon Ringle wrote: >> >> >> On Tue, Jan 21, 2014 at 4:56 AM, Michael Olbrich >> >> >> wrote: >> >> >> > Hi, >> >> >> > >> >> >> > On Mon, Jan 20, 2014 at 08:32:29PM -0500, Jon Ringle wrote: >> >> >> >> When generating the ${PTXDIST_TEMPDIR}/pkghash-* in ptxd_lib_dgen.awk, >> >> >> >> have you considered adding to that the contents of the first >> >> >> >> ${PTXDIST_PATH_PATCHES}/this_PKG/series file found if one exists? This >> >> >> >> would make the *_CFGHASH change if the patch series changes for a >> >> >> >> given package. I'm not sure how to do this in awk, since >> >> >> >> ${PTXDIST_PATH_PATCHES} is actually a : delimited search path. >> >> >> > >> >> >> > It's not that simple. There are also things like $(KERNEL_SERIES) and the >> >> >> > last time I tried, the performance was not acceptable. >> >> >> >> >> >> Does the special case for $(KERNEL_SERIES) go away with what is being >> >> >> discussed on the other thread today about adding >> >> >> KERNEL_DEVPKG := NO >> >> > >> >> > Now I remember why that doesn't work: >> >> > The name for the individual patch directories are not available yet, so we >> >> > cannot find the series file. :-/ >> >> >> >> It would be great if there was someway to get the series file so it >> >> could be included in pkghash-*. I've been bitten by adding a custom >> >> patch to a package only to have the old dev package used because the >> >> series file change was not detected. >> > >> > I agree, but I have no idea how to do this. >> >> Does the value of _CFGHASH need to be generated in >> scripts/lib/ptxd_lib_dgen.awk? >> Why not have a dependency on ${PTXDIST_TEMPDIR}/pkghash- so that >> the md5sum is calculated later... > > I don't think that's possible. We change the dependencies based on the > existence of the devpkg: > > "get -> extract -> prepare -> compile -> install -> targetinstall" > or > "unpack -> targetinstall" > > This can only happen at the beginning, when the make dependencies are > resolved. I don't think this can be delayed. Can we do this in 2 passes then? Have ptxdist call "ptxd_make_log build_pkghash" first where the target builds the pkghash-* files at a time where it can call ptxd_make_world_patchin_apply_init to figure out the location of the series file, do_go() { check_premake_compiler && ptxd_make_log build_pkghash && ptxd_make_log world } -- ptxdist mailing list ptxdist@pengutronix.de