mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Jon Ringle <jon@ringle.org>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] Add patch series to ${PTXDIST_TEMPDIR}/pkghash-*
Date: Fri, 24 Jan 2014 10:25:43 -0500	[thread overview]
Message-ID: <CAMwGMjxPCuw1og2Q4SMpLB-2=xEVQz=vJA4adYfUBgVny-8G8Q@mail.gmail.com> (raw)
In-Reply-To: <20140124150315.GE7704@pengutronix.de>

On Fri, Jan 24, 2014 at 10:03 AM, Michael Olbrich
<m.olbrich@pengutronix.de> wrote:
> On Fri, Jan 24, 2014 at 08:45:42AM -0500, Jon Ringle wrote:
>> On Fri, Jan 24, 2014 at 4:16 AM, Michael Olbrich
>> <m.olbrich@pengutronix.de> wrote:
>> > On Thu, Jan 23, 2014 at 12:30:11PM -0500, Jon Ringle wrote:
>> >> On Thu, Jan 23, 2014 at 11:10 AM, Michael Olbrich
>> >> <m.olbrich@pengutronix.de> wrote:
>> >> > On Tue, Jan 21, 2014 at 09:02:49AM -0500, Jon Ringle wrote:
>> >> >> On Tue, Jan 21, 2014 at 4:56 AM, Michael Olbrich
>> >> >> <m.olbrich@pengutronix.de> wrote:
>> >> >> > Hi,
>> >> >> >
>> >> >> > On Mon, Jan 20, 2014 at 08:32:29PM -0500, Jon Ringle wrote:
>> >> >> >> When generating the ${PTXDIST_TEMPDIR}/pkghash-* in ptxd_lib_dgen.awk,
>> >> >> >> have you considered adding to that the contents of the first
>> >> >> >> ${PTXDIST_PATH_PATCHES}/this_PKG/series file found if one exists? This
>> >> >> >> would make the *_CFGHASH change if the patch series changes for a
>> >> >> >> given package. I'm not sure how to do this in awk, since
>> >> >> >> ${PTXDIST_PATH_PATCHES} is actually a : delimited search path.
>> >> >> >
>> >> >> > It's not that simple. There are also things like $(KERNEL_SERIES) and the
>> >> >> > last time I tried, the performance was not acceptable.
>> >> >>
>> >> >> Does the special case for $(KERNEL_SERIES) go away with what is being
>> >> >> discussed on the other thread today about adding
>> >> >> KERNEL_DEVPKG := NO
>> >> >
>> >> > Now I remember why that doesn't work:
>> >> > The name for the individual patch directories are not available yet, so we
>> >> > cannot find the series file. :-/
>> >>
>> >> It would be great if there was someway to get the series file so it
>> >> could be included in pkghash-*. I've been bitten by adding a custom
>> >> patch to a package only to have the old dev package used because the
>> >> series file change was not detected.
>> >
>> > I agree, but I have no idea how to do this.
>>
>> Does the value of <PKG>_CFGHASH need to be generated in
>> scripts/lib/ptxd_lib_dgen.awk?
>> Why not have a dependency on ${PTXDIST_TEMPDIR}/pkghash-<pkg> so that
>> the md5sum is calculated later...
>
> I don't think that's possible. We change the dependencies based on the
> existence of the devpkg:
>
> "get -> extract -> prepare -> compile -> install -> targetinstall"
> or
> "unpack -> targetinstall"
>
> This can only happen at the beginning, when the make dependencies are
> resolved. I don't think this can be delayed.

Can we do this in 2 passes then? Have ptxdist call "ptxd_make_log
build_pkghash" first where the target builds the pkghash-* files at a
time where it can call ptxd_make_world_patchin_apply_init to figure
out the location of the series file,

do_go()
{
    check_premake_compiler &&
    ptxd_make_log build_pkghash &&
    ptxd_make_log world
}

-- 
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2014-01-24 15:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-21  1:32 Jon Ringle
2014-01-21  9:56 ` Michael Olbrich
2014-01-21 14:02   ` Jon Ringle
2014-01-23 16:10     ` Michael Olbrich
2014-01-23 17:30       ` Jon Ringle
2014-01-24  9:16         ` Michael Olbrich
2014-01-24 13:45           ` Jon Ringle
2014-01-24 15:03             ` Michael Olbrich
2014-01-24 15:25               ` Jon Ringle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMwGMjxPCuw1og2Q4SMpLB-2=xEVQz=vJA4adYfUBgVny-8G8Q@mail.gmail.com' \
    --to=jon@ringle.org \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox