[ptxdist] BASH_FUNC_set_shell_label() not a valid identifier

[ptxdist] BASH_FUNC_set_shell_label() not a valid identifier

[Jon Ringle]

[-- Attachment #1.1: Type: text/plain, Size: 694 bytes --]

Recently I've started to see the following message every time I invoke
ptxdist:

/usr/local/lib/ptxdist-2014.10.0/bin/ptxdist: line 2151: unset:
`BASH_FUNC_set_shell_label()': not a valid identifier

The ptxdist code here has:
    unset $(/usr/bin/env | \
        sed -n -e "s/^\([^=[:space:]]\+\)=.*$/\1/p" | \
        egrep -v
"^(PTXDIST_PTXRC|PTX_AUTOBUILD_DESTDIR|CCACHE_.*|PWD|HOME|USER|PATH|TERM|COLUMNS|LINES|DISPLAY|TMPDIR|http_proxy|https_proxy|ftp_proxy|no_proxy${whitelist})$"
)

I'm not sure why I'm getting this message, but speculatively it seems to
have started appearing after I updated Ubuntu-14.04 with bash shellshock
patches... ?

Anyone else see this type of message?

Jon

[-- Attachment #1.2: Type: text/html, Size: 942 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] BASH_FUNC_set_shell_label() not a valid identifier

[Alexander Dahl]

Hei hei, 

Am 2014-10-05 06:47, schrieb Jon Ringle:
> I'm not sure why I'm getting this message, but speculatively it seems to
> have started appearing after I updated Ubuntu-14.04 with bash shellshock
> patches... ?
> 
> Anyone else see this type of message?

Same here on Debian 7 (wheezy) and I had the same assumption. I work
with zsh, but I also see those messages. 8-)

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] BASH_FUNC_set_shell_label() not a valid identifier

[Bruno Thomsen]

Hello,


>> I'm not sure why I'm getting this message, but speculatively it seems 
>> to have started appearing after I updated Ubuntu-14.04 with bash 
>> shellshock patches... ?
>> 
>> Anyone else see this type of message?
>
> Same here on Debian 7 (wheezy) and I had the same assumption. I work with zsh, but I also see those messages. 8-)

I have just searched the logs from our build server and it does not seems to be affected.

ptxdist-2013.12.0 (+ some mainline rules)
Ubuntu 14.04 LTS
GNU bash, version 4.3.11(1)-release (x86_64-pc-linux-gnu)


Venlig hilsen / Best regards

Kamstrup A/S <http://www.kamstrup.dk> 
Bruno Thomsen
Development engineer
Technology

Kamstrup A/S
Industrivej 28
DK-8660 Skanderborg
Tel:	 +45 89 93 10 00	 
Fax:	 +45 89 93 10 01	 
Dir:	 +45 89 93 13 94	 
E-mail:	 bth@kamstrup.dk	 
Web:	 www.kamstrup.dk	
-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] BASH_FUNC_set_shell_label() not a valid identifier

[Tim Sander]

Hi
> >> I'm not sure why I'm getting this message, but speculatively it seems
> >> to have started appearing after I updated Ubuntu-14.04 with bash
> >> shellshock patches... ?
It might have s.th. to do with the ShellShock patches, have not seen this 
error before but I think this is only for older repositories like 2014.06.0 
i don't see this error with 2014.09.0.

Best regards
Tim

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] BASH_FUNC_set_shell_label() not a valid identifier

[Spriggs, Jim]

Hi Guys,

just confirming this, because it has been puzzling me also for the last week or so.

> bash --version
GNU bash, version 4.2.47(1)-release (i586-suse-linux-gnu)

> type mc
mc is a function
mc ()
{
    . /usr/share/mc/mc-wrapper.sh
}

> ./p --version
./p: line 2115: unset: `BASH_FUNC_mc()': not a valid identifier
2014.07.0
>

MfG,
--
jim

-----Ursprüngliche Nachricht-----
Von: ptxdist-bounces@pengutronix.de [mailto:ptxdist-bounces@pengutronix.de] Im Auftrag von Tim Sander
Gesendet: Montag, 6. Oktober 2014 11:19
An: ptxdist@pengutronix.de
Betreff: Re: [ptxdist] BASH_FUNC_set_shell_label() not a valid identifier

Hi
> >> I'm not sure why I'm getting this message, but speculatively it
> >> seems to have started appearing after I updated Ubuntu-14.04 with
> >> bash shellshock patches... ?
It might have s.th. to do with the ShellShock patches, have not seen this error before but I think this is only for older repositories like 2014.06.0 i don't see this error with 2014.09.0.

Best regards
Tim

--
ptxdist mailing list
ptxdist@pengutronix.de

________________________________

RAYLASE AG
Argelsrieder Feld 2+4
82234 Wessling
Germany
Tel.: +49-(0)8153/88 98-0
Fax: +49-(0)8153/88 98-10
http://www.raylase.de

District Court Munich, HRB 131450

Board: Peter von Jan (CEO)

Supervisory Board: Dr. Ulrich Lohmann (Chairman)


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] BASH_FUNC_set_shell_label() not a valid identifier

[Jon Ringle]

This page has a good explanation of shellshock, including where
BASH_FUNC_ prefix comes from. It appears that there are variations on
the prefix and suffix that is added to an exported function's name

http://www.dwheeler.com/essays/shellshock.html


On Thu, Oct 9, 2014 at 3:50 AM, Spriggs, Jim <J.Spriggs@raylase.de> wrote:
> Hi Guys,
>
> just confirming this, because it has been puzzling me also for the last week or so.
>
>> bash --version
> GNU bash, version 4.2.47(1)-release (i586-suse-linux-gnu)
>
>> type mc
> mc is a function
> mc ()
> {
>     . /usr/share/mc/mc-wrapper.sh
> }
>
>> ./p --version
> ./p: line 2115: unset: `BASH_FUNC_mc()': not a valid identifier
> 2014.07.0
>>
>
> MfG,
> --
> jim
>
> -----Ursprüngliche Nachricht-----
> Von: ptxdist-bounces@pengutronix.de [mailto:ptxdist-bounces@pengutronix.de] Im Auftrag von Tim Sander
> Gesendet: Montag, 6. Oktober 2014 11:19
> An: ptxdist@pengutronix.de
> Betreff: Re: [ptxdist] BASH_FUNC_set_shell_label() not a valid identifier
>
> Hi
>> >> I'm not sure why I'm getting this message, but speculatively it
>> >> seems to have started appearing after I updated Ubuntu-14.04 with
>> >> bash shellshock patches... ?
> It might have s.th. to do with the ShellShock patches, have not seen this error before but I think this is only for older repositories like 2014.06.0 i don't see this error with 2014.09.0.
>
> Best regards
> Tim
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
> ________________________________
>
> RAYLASE AG
> Argelsrieder Feld 2+4
> 82234 Wessling
> Germany
> Tel.: +49-(0)8153/88 98-0
> Fax: +49-(0)8153/88 98-10
> http://www.raylase.de
>
> District Court Munich, HRB 131450
>
> Board: Peter von Jan (CEO)
>
> Supervisory Board: Dr. Ulrich Lohmann (Chairman)
>
>
> Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
>
> This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] BASH_FUNC_set_shell_label() not a valid identifier

[Michael Olbrich]

Hi,

On Sun, Oct 05, 2014 at 12:47:49AM -0400, Jon Ringle wrote:
> Recently I've started to see the following message every time I invoke
> ptxdist:
> 
> /usr/local/lib/ptxdist-2014.10.0/bin/ptxdist: line 2151: unset:
> `BASH_FUNC_set_shell_label()': not a valid identifier
> 
> The ptxdist code here has:
>     unset $(/usr/bin/env | \
>         sed -n -e "s/^\([^=[:space:]]\+\)=.*$/\1/p" | \
>         egrep -v
> "^(PTXDIST_PTXRC|PTX_AUTOBUILD_DESTDIR|CCACHE_.*|PWD|HOME|USER|PATH|TERM|COLUMNS|LINES|DISPLAY|TMPDIR|http_proxy|https_proxy|ftp_proxy|no_proxy${whitelist})$"
> )
> 
> I'm not sure why I'm getting this message, but speculatively it seems to
> have started appearing after I updated Ubuntu-14.04 with bash shellshock
> patches... ?
> 
> Anyone else see this type of message?

$ some_function() { echo foo; }
$ export -f some_function

Debian/sid (with shellshock patches):

$ bash --version
GNU bash, version 4.3.27(1)-release (x86_64-pc-linux-gnu)
[...]
$ env
[...]
some_function=() {  echo foo
}
[...]

Debian/wheezy (with shellshock patches):

$ bash --version
GNU bash, version 4.2.37(1)-release (i486-pc-linux-gnu)
$ env
[...]
BASH_FUNC_some_function()=() {  echo foo
}
[...]

Not nice :-/. So we need to convert 'BASH_FUNC_<something>()' ->
'<something>' before calling 'unset'.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de