mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Jon Ringle <jon@ringle.org>
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] glib: Patch glib-2.0.pc.in to use '-isystem dir' rather than '-Idir'
Date: Sat, 3 Oct 2015 09:11:39 -0400	[thread overview]
Message-ID: <CAMwGMjxGPZZQN+ucHoW_J1TU=kAb-cNsg+EZkyxGr7FCwFK8rQ@mail.gmail.com> (raw)
In-Reply-To: <560F982A.7020904@pengutronix.de>

On Sat, Oct 3, 2015 at 4:56 AM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 10/03/2015 05:06 AM, jon@ringle.org wrote:
>> From: Jon Ringle <jringle@gridpoint.com>
>>
>> When ptxdist did a bump to glib-2.44.0, a project that uses glib and builds
>> with -Werror will fail.
>>
>> This patch will allow projects that use -Werror to continue to build without
>> error.
>>
>> This patch was submitted upstream:
>> https://bugzilla.gnome.org/show_bug.cgi?id=756005
>>
>> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
>> ---
>>  ....0.pc.in-use-isystem-dir-rather-than-Idir.patch | 90 ++++++++++++++++++++++
>>  patches/glib-2.44.0/series                         |  4 +
>>  2 files changed, 94 insertions(+)
>>  create mode 100644 patches/glib-2.44.0/0001-glib-2.0.pc.in-use-isystem-dir-rather-than-Idir.patch
>>  create mode 100644 patches/glib-2.44.0/series
>>
>> diff --git a/patches/glib-2.44.0/0001-glib-2.0.pc.in-use-isystem-dir-rather-than-Idir.patch b/patches/glib-2.44.0/0001-glib-2.0.pc.in-use-isystem-dir-rather-than-Idir.patch
>> new file mode 100644
>> index 0000000..c524878
>> --- /dev/null
>> +++ b/patches/glib-2.44.0/0001-glib-2.0.pc.in-use-isystem-dir-rather-than-Idir.patch
>> @@ -0,0 +1,90 @@
>> +From: Jon Ringle <jringle@gridpoint.com>
>> +Date: Fri, 2 Oct 2015 22:44:07 -0400
>> +Subject: [PATCH] glib-2.0.pc.in: use '-isystem dir' rather than '-Idir'
>> +
>> +glib produces warnings in that gcc will turn to errors when a project builds
>> +with -Werror:
>> +/usr/include/glib-2.0/gio/glistmodel.h: In function 'GListModel* G_LIST_MODEL(gconstpointer)':
>    ^^^^^^^^^^^^^^^^^^^^^
>
> this doesn't look correct when cross compiling.

Maybe I shouldn't have done so, but for the purpose of the patch being
sent upstream, I stripped off the leading part of the path. They all
look like:
/home/local/GRIDPOINT/jringle/code/gpec/ec1k-rootfs/platform-EC1K/sysroot-target/usr/include/glib-2.0/gio/glistmodel.h:
In function 'GListModel* G_LIST_MODEL(gconstpointer)':

-Jon

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2015-10-03 13:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-03  3:06 jon
2015-10-03  8:56 ` Marc Kleine-Budde
2015-10-03 13:11   ` Jon Ringle [this message]
2015-10-16 14:02     ` Jon Ringle
2015-10-30 10:22       ` Michael Olbrich
2015-10-30 15:45         ` Jon Ringle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMwGMjxGPZZQN+ucHoW_J1TU=kAb-cNsg+EZkyxGr7FCwFK8rQ@mail.gmail.com' \
    --to=jon@ringle.org \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox