From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <jonringle@gmail.com>) id 1Wcd5T-0005lj-Ji
	for ptxdist@pengutronix.de; Tue, 22 Apr 2014 17:58:29 +0200
Received: by mail-lb0-f175.google.com with SMTP id w7so4433195lbi.6
	for <ptxdist@pengutronix.de>; Tue, 22 Apr 2014 08:58:18 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1397747491-27403-1-git-send-email-jon@ringle.org>
References: <1397747491-27403-1-git-send-email-jon@ringle.org>
Date: Tue, 22 Apr 2014 11:58:18 -0400
Message-ID: <CAMwGMjxB4tB7ONxW0RRF4OGsWQcrGgVKX=T-i=rzYuGPGy+QkQ@mail.gmail.com>
From: Jon Ringle <jon@ringle.org>
Subject: Re: [ptxdist] [PATCH v3] image_tgz: Make label optional
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>

ping...

On Thu, Apr 17, 2014 at 11:11 AM,  <jon@ringle.org> wrote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
>  platforms/image_tgz.in    | 23 +++++++++++++++++++++--
>  rules/post/image_tgz.make |  8 ++++++--
>  2 files changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/platforms/image_tgz.in b/platforms/image_tgz.in
> index 17b0aed..c583bbc 100644
> --- a/platforms/image_tgz.in
> +++ b/platforms/image_tgz.in
> @@ -1,8 +1,27 @@
>  ## SECTION=image
>
> -config IMAGE_TGZ
> +menuconfig IMAGE_TGZ
>         bool
> -       prompt "Generate images/root.tgz"
> +       prompt "Generate images/root.tgz      "
>         help
>           Build a tar.gz archive of the root filesystem, containing the
>           right owner/group and access permissions.
> +
> +if IMAGE_TGZ
> +
> +config IMAGE_TGZ_INCLUDE_LABEL
> +       bool
> +       prompt "Include label"
> +       help
> +         Create tgz image with a label
> +
> +if IMAGE_TGZ_INCLUDE_LABEL
> +config IMAGE_TGZ_LABEL
> +       string
> +       prompt "label"
> +       default "${PTXCONF_PROJECT_VENDOR}-${PTXCONF_PROJECT}${PTXCONF_PROJECT_VERSION}"
> +       help
> +         This string gets expanded to form the label. An empty string produces no label.
> +
> +endif
> +endif
> diff --git a/rules/post/image_tgz.make b/rules/post/image_tgz.make
> index 019077d..6211822 100644
> --- a/rules/post/image_tgz.make
> +++ b/rules/post/image_tgz.make
> @@ -10,12 +10,16 @@
>
>  SEL_ROOTFS-$(PTXCONF_IMAGE_TGZ)                += $(IMAGEDIR)/root.tgz
>
> +ifdef PTXCONF_IMAGE_TGZ_LABEL
> +IMAGE_TGZ_LABEL="--label $(PTXCONF_IMAGE_TGZ_LABEL)"
> +endif
> +
>  ifdef PTXCONF_IMAGE_TGZ
>  $(IMAGEDIR)/root.tgz: $(STATEDIR)/image_working_dir
> -       @echo -n "Creating root.tgz from working dir with label..."
> +       @echo -n "Creating root.tgz from working dir: ${IMAGE_TGZ_LABEL} "
>         @cd $(image/work_dir);                                                  \
>         (awk -F: $(DOPERMISSIONS) $(image/permissions) &&               \
> -       (       echo -n "tar --label '${PTXCONF_PROJECT_VENDOR}-${PTXCONF_PROJECT}${PTXCONF_PROJECT_VERSION}' -zcf ";   \
> +       (       echo -n "tar ${IMAGE_TGZ_LABEL} -zcf "; \
>                 echo -n "$@ ." )                                        \
>         ) | $(FAKEROOT) --
>         @echo "done."
> --
> 1.8.5.4
>

-- 
ptxdist mailing list
ptxdist@pengutronix.de