mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Jon Ringle <jon@ringle.org>
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] [PATCH v3] image_tgz: Make label optional
Date: Tue, 22 Apr 2014 11:58:18 -0400	[thread overview]
Message-ID: <CAMwGMjxB4tB7ONxW0RRF4OGsWQcrGgVKX=T-i=rzYuGPGy+QkQ@mail.gmail.com> (raw)
In-Reply-To: <1397747491-27403-1-git-send-email-jon@ringle.org>

ping...

On Thu, Apr 17, 2014 at 11:11 AM,  <jon@ringle.org> wrote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
>  platforms/image_tgz.in    | 23 +++++++++++++++++++++--
>  rules/post/image_tgz.make |  8 ++++++--
>  2 files changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/platforms/image_tgz.in b/platforms/image_tgz.in
> index 17b0aed..c583bbc 100644
> --- a/platforms/image_tgz.in
> +++ b/platforms/image_tgz.in
> @@ -1,8 +1,27 @@
>  ## SECTION=image
>
> -config IMAGE_TGZ
> +menuconfig IMAGE_TGZ
>         bool
> -       prompt "Generate images/root.tgz"
> +       prompt "Generate images/root.tgz      "
>         help
>           Build a tar.gz archive of the root filesystem, containing the
>           right owner/group and access permissions.
> +
> +if IMAGE_TGZ
> +
> +config IMAGE_TGZ_INCLUDE_LABEL
> +       bool
> +       prompt "Include label"
> +       help
> +         Create tgz image with a label
> +
> +if IMAGE_TGZ_INCLUDE_LABEL
> +config IMAGE_TGZ_LABEL
> +       string
> +       prompt "label"
> +       default "${PTXCONF_PROJECT_VENDOR}-${PTXCONF_PROJECT}${PTXCONF_PROJECT_VERSION}"
> +       help
> +         This string gets expanded to form the label. An empty string produces no label.
> +
> +endif
> +endif
> diff --git a/rules/post/image_tgz.make b/rules/post/image_tgz.make
> index 019077d..6211822 100644
> --- a/rules/post/image_tgz.make
> +++ b/rules/post/image_tgz.make
> @@ -10,12 +10,16 @@
>
>  SEL_ROOTFS-$(PTXCONF_IMAGE_TGZ)                += $(IMAGEDIR)/root.tgz
>
> +ifdef PTXCONF_IMAGE_TGZ_LABEL
> +IMAGE_TGZ_LABEL="--label $(PTXCONF_IMAGE_TGZ_LABEL)"
> +endif
> +
>  ifdef PTXCONF_IMAGE_TGZ
>  $(IMAGEDIR)/root.tgz: $(STATEDIR)/image_working_dir
> -       @echo -n "Creating root.tgz from working dir with label..."
> +       @echo -n "Creating root.tgz from working dir: ${IMAGE_TGZ_LABEL} "
>         @cd $(image/work_dir);                                                  \
>         (awk -F: $(DOPERMISSIONS) $(image/permissions) &&               \
> -       (       echo -n "tar --label '${PTXCONF_PROJECT_VENDOR}-${PTXCONF_PROJECT}${PTXCONF_PROJECT_VERSION}' -zcf ";   \
> +       (       echo -n "tar ${IMAGE_TGZ_LABEL} -zcf "; \
>                 echo -n "$@ ." )                                        \
>         ) | $(FAKEROOT) --
>         @echo "done."
> --
> 1.8.5.4
>

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2014-04-22 15:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17 15:11 jon
2014-04-22 15:58 ` Jon Ringle [this message]
2014-04-22 16:08 ` Michael Olbrich
2014-04-22 16:21 jon
2014-04-23  6:52 ` Michael Olbrich
2014-04-23 12:00   ` Jon Ringle
2014-05-21 15:03   ` Alexander Dahl
2014-05-26  7:13     ` Alexander Dahl
2014-06-02  9:17       ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMwGMjxB4tB7ONxW0RRF4OGsWQcrGgVKX=T-i=rzYuGPGy+QkQ@mail.gmail.com' \
    --to=jon@ringle.org \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox