From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
MIME-Version: 1.0
References: <CAMwGMjx7mF3MOA5-ZPGC=F3SY44ORTmiFd57sn=+SEA7+S=ygw@mail.gmail.com>
In-Reply-To: <CAMwGMjx7mF3MOA5-ZPGC=F3SY44ORTmiFd57sn=+SEA7+S=ygw@mail.gmail.com>
From: Jon Ringle <jon@ringle.org>
Date: Mon, 20 Apr 2020 14:16:30 -0400
Message-ID: <CAMwGMjxAd09Eo72VD--=6ju2D4h8b1_J3ZWh2d7M45P=k5UeDg@mail.gmail.com>
Subject: Re: [ptxdist] reproducible timestamps in ipkg package
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: multipart/mixed; boundary="===============0739011928=="
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.com

--===============0739011928==
Content-Type: multipart/alternative; boundary="0000000000009d87d005a3bce659"

--0000000000009d87d005a3bce659
Content-Type: text/plain; charset="UTF-8"

On Mon, Apr 20, 2020 at 12:28 PM Jon Ringle <jon@ringle.org> wrote:

> I am having an issue where the timestamps for the files in the ipkg have
> the current timestamp instead of the reproducible timestamp coming from
> SOURCE_DATE_EPOCH.
> I added a debug log message to ptxd_install_fixup_timestamps() found in
> scripts/lib/ptxd_make_xpkg_pkg.sh to show the timestamp being used:
>
> ptxd_install_fixup_timestamps() {
>     local timestamp="@${SOURCE_DATE_EPOCH}"
>     local touch_args
>     if touch --help | grep -q -- --no-dereference &> /dev/null; then
>         touch_args="--no-dereference"
>     fi
>
>     echo "ptxd_install_fixup_timestamps ${timestamp} ($(date
> --date=${timestamp}))"
>     find "${1}" -print0 | xargs -0 touch ${touch_args} -c -d "${timestamp}"
> }
>
> I am currently using ptxdist-2019.11.0, and I get the expected result when
> directly printing SOURCE_DATE_EPOCH:
> $ ptxdist print SOURCE_DATE_EPOCH
> 1572566400
> $ date --date=@$(ptxdist print SOURCE_DATE_EPOCH)
> Fri Nov  1 00:00:00 UTC 2019
>
> However, the debug output I added to ptxd_install_fixup_timestamps()
> produces this output that corresponds to the current datetime:
> ptxd_install_fixup_timestamps @1587399767 (Mon Apr 20 16:22:47 UTC 2020)
>
>
Ok... I found that this behavior is being caused by this code in
ptxd_make_world_init():

    #
    # check if we shall use a local work-in-progress tree instead
    # of the configured URL.
    #
    # If a link in local_src/<label>.<platform> exists and points to
    # a directory, use this instead of the real one.
    #
    local
wip_sources="${PTXDIST_WORKSPACE}/local_src/${pkg_label}${PTXDIST_PLATFORMSUFFIX}"
    if [ -d "$(readlink -f "${wip_sources}")" ]; then
        pkg_url="file://${wip_sources}"
        unset pkg_src
        # always use a new timestamp for wip builds
        SOURCE_DATE_EPOCH="$(echo $(date "+%s"))"
    fi

I would like to have a way to conditionally not set SOURCE_DATE_EPOCH in
this case. Suggestions anyone?

-Jon


> -Jon
>

--0000000000009d87d005a3bce659
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Apr 20, 2020 at 12:28 PM Jon =
Ringle &lt;<a href=3D"mailto:jon@ringle.org">jon@ringle.org</a>&gt; wrote:<=
br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"=
>I am having an issue where the timestamps for the files in the ipkg have t=
he current timestamp instead of the reproducible timestamp coming from SOUR=
CE_DATE_EPOCH.<div>I added a debug log message to ptxd_install_fixup_timest=
amps() found in scripts/lib/ptxd_make_xpkg_pkg.sh to show the timestamp bei=
ng used:</div><div><br></div><div>ptxd_install_fixup_timestamps() {<br>=C2=
=A0 =C2=A0 local timestamp=3D&quot;@${SOURCE_DATE_EPOCH}&quot;<br>=C2=A0 =
=C2=A0 local touch_args<br>=C2=A0 =C2=A0 if touch --help | grep -q -- --no-=
dereference &amp;&gt; /dev/null; then<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 touch_=
args=3D&quot;--no-dereference&quot;<br>=C2=A0 =C2=A0 fi<br><br>=C2=A0 =C2=
=A0 echo &quot;ptxd_install_fixup_timestamps ${timestamp} ($(date --date=3D=
${timestamp}))&quot;<br>=C2=A0 =C2=A0 find &quot;${1}&quot; -print0 | xargs=
 -0 touch ${touch_args} -c -d &quot;${timestamp}&quot;<br>}<br></div><div><=
br></div><div>I am currently using ptxdist-2019.11.0, and I get the expecte=
d result when directly printing SOURCE_DATE_EPOCH:<br>$ ptxdist print SOURC=
E_DATE_EPOCH<br>1572566400<br></div><div>$ date --date=3D@$(ptxdist print S=
OURCE_DATE_EPOCH)<br>Fri Nov =C2=A01 00:00:00 UTC 2019<br></div><div><br></=
div><div>However, the debug output I added to ptxd_install_fixup_timestamps=
() produces this output that corresponds to the current datetime:</div><div=
>ptxd_install_fixup_timestamps @1587399767 (Mon Apr 20 16:22:47 UTC 2020)<b=
r></div><div><br></div></div></blockquote><div><br></div><div>Ok... I found=
 that this behavior is being caused by this code in ptxd_make_world_init():=
</div><div><br></div><div>=C2=A0 =C2=A0 #<br>=C2=A0 =C2=A0 # check if we sh=
all use a local work-in-progress tree instead<br>=C2=A0 =C2=A0 # of the con=
figured URL.<br>=C2=A0 =C2=A0 #<br>=C2=A0 =C2=A0 # If a link in local_src/&=
lt;label&gt;.&lt;platform&gt; exists and points to<br>=C2=A0 =C2=A0 # a dir=
ectory, use this instead of the real one.<br>=C2=A0 =C2=A0 #<br>=C2=A0 =C2=
=A0 local wip_sources=3D&quot;${PTXDIST_WORKSPACE}/local_src/${pkg_label}${=
PTXDIST_PLATFORMSUFFIX}&quot;<br>=C2=A0 =C2=A0 if [ -d &quot;$(readlink -f =
&quot;${wip_sources}&quot;)&quot; ]; then<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 pk=
g_url=3D&quot;file://${wip_sources}&quot;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 un=
set pkg_src<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 # always use a new timestamp for=
 wip builds<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 SOURCE_DATE_EPOCH=3D&quot;$(echo=
 $(date &quot;+%s&quot;))&quot;<br>=C2=A0 =C2=A0 fi<br></div><div><br></div=
><div>I would like to have a way to conditionally not set SOURCE_DATE_EPOCH=
 in this case. Suggestions anyone?</div><div><br></div><div>-Jon</div><div>=
=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"l=
tr"><div></div><div>-Jon</div></div>
</blockquote></div></div>

--0000000000009d87d005a3bce659--


--===============0739011928==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

--===============0739011928==--