From: Jon Ringle <jon@ringle.org>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] ptxd_ipkg_rev_smaller: fix compare with empty micro
Date: Wed, 19 Oct 2011 15:55:10 -0400 [thread overview]
Message-ID: <CAMwGMjwiydmwoFozGJviKYwe22e-okAT2o4DRohFzoEYoJsbQw@mail.gmail.com> (raw)
In-Reply-To: <4E9F1C64.6040604@bwalle.de>
[-- Attachment #1.1: Type: text/plain, Size: 1182 bytes --]
On Wed, Oct 19, 2011 at 2:52 PM, Bernhard Walle <bernhard@bwalle.de> wrote:
> Am 19.10.2011 19:46, schrieb Robert Schwebel:
>
> On Tue, Oct 18, 2011 at 04:42:46AM -0400, Jon Ringle wrote:
>>
>>> After more testing, I found that there were other situations where the
>>> version
>>> comparison does not work well.
>>>
>>> I ended up replacing the implementation of ptxd_ipkg_rev_smaller() with
>>> something much simpler, albeit dependent on dpkg that seems to work well:
>>>
>>> ptxd_ipkg_rev_smaller() {
>>> dpkg --compare-versions $1 lt $2
>>> }
>>>
>>
>> Hmm, that makes us dependend on dpkg (and thus on Debian). PTXdist tries
>> hard to run on any distribution, so I'm not happy with this.
>>
>
> Maybe Perl would be okay?
>
> http://www.emdebian.org/trac/**browser/current/target/dpkg/**
> trunk/scripts/Dpkg/Version.pm?**rev=6998<http://www.emdebian.org/trac/browser/current/target/dpkg/trunk/scripts/Dpkg/Version.pm?rev=6998>
>
> Seems to be quite official, and the Dpkg::ErrorHandling and Dpkg::Gettext
> could be easily removed.
>
>
What do you think about the bash implementation found here:
http://lists.us.dell.com/pipermail/dkms-devel/2004-July/000142.html
Jon
[-- Attachment #1.2: Type: text/html, Size: 1878 bytes --]
[-- Attachment #2: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2011-10-19 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 23:21 Jon Ringle
2011-10-18 8:42 ` Jon Ringle
2011-10-19 17:46 ` Robert Schwebel
2011-10-19 18:52 ` Bernhard Walle
2011-10-19 19:55 ` Jon Ringle [this message]
2011-10-20 6:10 ` Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMwGMjwiydmwoFozGJviKYwe22e-okAT2o4DRohFzoEYoJsbQw@mail.gmail.com \
--to=jon@ringle.org \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox