From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-vw0-f50.google.com ([209.85.212.50])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <jonringle@gmail.com>) id 1R5r92-0007iV-6q
	for ptxdist@pengutronix.de; Tue, 20 Sep 2011 05:37:17 +0200
Received: by vws14 with SMTP id 14so160650vws.37
	for <ptxdist@pengutronix.de>; Mon, 19 Sep 2011 20:37:10 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1313579150-8834-1-git-send-email-bernhard@bwalle.de>
References: <20110817095613.GU20524@pengutronix.de>
	<1313579150-8834-1-git-send-email-bernhard@bwalle.de>
Date: Mon, 19 Sep 2011 23:37:10 -0400
Message-ID: <CAMwGMjwRTGc8FbmhrEzBh=MVmhRG_iaj_W5D0Cu2ZS74zbo9=w@mail.gmail.com>
From: Jon Ringle <jon@ringle.org>
Subject: Re: [ptxdist] [PATCH 1/2] udev: Use ptxdist kernel headers
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de
Cc: Bernhard Walle <walle@corscience.de>

On Wed, Aug 17, 2011 at 7:05 AM,  <bernhard@bwalle.de> wrote:
> From: Bernhard Walle <walle@corscience.de>
>
> When a toolchain without kernel headers (such as the Lite version from
> Codesourcery) or with very old kernel header is used, udev doesn't build
> because videodev.h is missing.
>
> This patch adds the $(KERNEL_HEADERS_INCLUDE_DIR) to the include path of
> udev like it's done for busybox or barebox.
>
> Tested on ARM with kernel headers 2.6.36.4 (the version
> OSELAS.Toolchain() is currently using).
>
> Signed-off-by: Bernhard Walle <walle@corscience.de>
> ---
> =A0rules/udev.make | =A0 =A05 +++++
> =A01 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/rules/udev.make b/rules/udev.make
> index ac2f0d4..b57bd01 100644
> --- a/rules/udev.make
> +++ b/rules/udev.make
> @@ -47,6 +47,11 @@ $(UDEV_SOURCE):
>
> =A0#
> =A0# autoconf
> +
> +UDEV_CONF_ENV :=3D \
> + =A0 =A0 =A0 $(CROSS_ENV) \
> + =A0 =A0 =A0 CPPFLAGS=3D"-I$(KERNEL_HEADERS_INCLUDE_DIR) $(CROSS_CPPFLAG=
S)"
> +

This breaks udev for me. #include <scsi/scsi.h> includes the wrong header f=
ile:

--------------------
target: udev.compile
--------------------

make[1]: Entering directory
`${PTXDIST_WORKSPACE}/platform-initramfs-ISC/build-target/udev-162'
make --no-print-directory all-recursive
Making all in .
  CC     libudev/libudev.lo
  CC     libudev/libudev-list.lo
  CC     libudev/libudev-util.lo
  CC     libudev/libudev-device.lo
  CC     libudev/libudev-enumerate.lo
  CC     libudev/libudev-monitor.lo
  CC     libudev/libudev-queue.lo
  CC     libudev/libudev-ctrl.lo
  CC     libudev/libudev-util-private.lo
  CC     libudev/libudev-device-private.lo
  CC     libudev/libudev-queue-private.lo
  CC     extras/firmware/extras_firmware_firmware-firmware.o
  CC     extras/ata_id/ata_id.o
  CC     extras/cdrom_id/cdrom_id.o
  CC     extras/collect/collect.o
  CC     extras/edd_id/edd_id.o
  CC     extras/floppy/create_floppy_devices.o
In file included from extras/ata_id/ata_id.c:32:0:
${PTXDIST_WORKSPACE}/platform-initramfs-ISC/sysroot-target/kernel-headers/i=
nclude/scsi/scsi.h:152:2:
error: expected specifier-qualifier-list before 'u8'
${PTXDIST_WORKSPACE}/platform-initramfs-ISC/sysroot-target/kernel-headers/i=
nclude/scsi/scsi.h:
In function 'scsi_varlen_cdb_length':
${PTXDIST_WORKSPACE}/platform-initramfs-ISC/sysroot-target/kernel-headers/i=
nclude/scsi/scsi.h:163:44:
error: 'struct scsi_varlen_cdb_hdr' has no member named
'additional_cdb_length'
make[3]: *** [extras/ata_id/ata_id.o] Error 1
make[3]: *** Waiting for unfinished jobs....
  CC     extras/input_id/input_id.o
make[2]: *** [all-recursive] Error 1
make[1]: Leaving directory
`${PTXDIST_WORKSPACE}/platform-initramfs-ISC/build-target/udev-162'
make[1]: *** [all] Error 2
make: *** [${PTXDIST_WORKSPACE}/platform-initramfs-ISC/state/udev.compile]
Error 2

Jon

-- =

ptxdist mailing list
ptxdist@pengutronix.de