From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-gx0-f172.google.com ([209.85.161.172])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <jonringle@gmail.com>) id 1RG5G9-0004Vq-HS
	for ptxdist@pengutronix.de; Tue, 18 Oct 2011 10:42:55 +0200
Received: by ggnv1 with SMTP id v1so423474ggn.31
	for <ptxdist@pengutronix.de>; Tue, 18 Oct 2011 01:42:46 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1318893704-23961-1-git-send-email-jon@ringle.org>
References: <1318893704-23961-1-git-send-email-jon@ringle.org>
Date: Tue, 18 Oct 2011 04:42:46 -0400
Message-ID: <CAMwGMjwRFb17Z4kZOi+13ucnjjWKE8fmebPTgSxVXPVorxk=Mg@mail.gmail.com>
From: Jon Ringle <jon@ringle.org>
Subject: Re: [ptxdist] [PATCH] ptxd_ipkg_rev_smaller: fix compare with empty
	micro
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============0622788959=="
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

--===============0622788959==
Content-Type: multipart/alternative; boundary=bcaec531496529c7ff04af8eb5ed

--bcaec531496529c7ff04af8eb5ed
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Oct 17, 2011 at 7:21 PM, Jon Ringle <jon@ringle.org> wrote:

> ptxd_ipkg_rev_smaller will return the wrong value if the version number
> does not include a $micro component.
>

For example:
>        pkgd_ipkg_rev_smaller foo_1.0-2_armel.ipk foo_1.0-1_armel.ipk
> will incorrectly return 0
>
>
After more testing, I found that there were other situations where the
version comparison does not work well.

I ended up replacing the implementation of ptxd_ipkg_rev_smaller() with
something much simpler, albeit dependent on dpkg that seems to work well:

ptxd_ipkg_rev_smaller() {
    dpkg --compare-versions $1 lt $2
}

--bcaec531496529c7ff04af8eb5ed
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Mon, Oct 17, 2011 at 7:21 PM, Jon Ringle <spa=
n dir=3D"ltr">&lt;<a href=3D"mailto:jon@ringle.org">jon@ringle.org</a>&gt;<=
/span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex;">
ptxd_ipkg_rev_smaller will return the wrong value if the version number<br>
does not include a $micro component.<br>=A0</blockquote><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex;">
For example:<br>
 =A0 =A0 =A0 =A0pkgd_ipkg_rev_smaller foo_1.0-2_armel.ipk foo_1.0-1_armel.i=
pk<br>
will incorrectly return 0<br>
<br></blockquote><div><br></div><div>After more testing, I found that there=
 were other situations where the version comparison does not work well.</di=
v><div><br></div><div>I ended up replacing the implementation of ptxd_ipkg_=
rev_smaller() with something much simpler, albeit dependent on dpkg that se=
ems to work well:</div>
<div><br></div><div><div>ptxd_ipkg_rev_smaller() {</div><div>=A0 =A0 dpkg -=
-compare-versions $1 lt $2</div><div>}</div></div><div><br></div></div>

--bcaec531496529c7ff04af8eb5ed--


--===============0622788959==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-- 
ptxdist mailing list
ptxdist@pengutronix.de

--===============0622788959==--