From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from eu1sys200aog127.obsmtp.com ([207.126.144.176])
	by metis.ext.pengutronix.de with smtp (Exim 4.72)
	(envelope-from <mh@newtec.dk>) id 1Y9CK4-00077W-1H
	for ptxdist@pengutronix.de; Thu, 08 Jan 2015 13:36:20 +0100
Received: by mail-wi0-f182.google.com with SMTP id h11so2969391wiw.3
	for <ptxdist@pengutronix.de>; Thu, 08 Jan 2015 04:36:19 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20150108115820.GD31136@pengutronix.de>
References: <1420706596-10898-1-git-send-email-mh@newtec.dk>
	<20150108115820.GD31136@pengutronix.de>
Date: Thu, 8 Jan 2015 13:36:19 +0100
Message-ID: <CAKmi1bXYSL635+96ZmUfKaePevQbgUauXi0tYZqD_0TmM1qfwA@mail.gmail.com>
From: Martin Hejnfelt <mh@newtec.dk>
Subject: Re: [ptxdist] [oracle java7 jre 1/1] Added Oracles Java 7 JRE
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi Michael,

2015-01-08 12:58 GMT+01:00 Michael Olbrich <m.olbrich@pengutronix.de>:
>
> Any reason to use java7 and not java8?

Only reason is that I am developing for Java 7, and want to keep the
compatibility (or at least not introduce any issues, simply for
versioning). In my opinion, you should have both if anything.

>
>> +config ORACLE_JAVA7_JRE_TARGET_PREFIX
>> +     string
>> +     depends on ORACLE_JAVA7_JRE
>> +     default "/usr/lib/jvm"
>> +     prompt "PREFIX for JRE 7"
>> +     help
>> +       Where should the JRE be installed.
>
> Do we need this? I think we can just hardcode this path.
>

I agree, I'll change that.

>> +
>> +# ----------------------------------------------------------------------------
>> +# Get
>> +# ----------------------------------------------------------------------------
>> +
>> +$(ORACLE_JAVA7_JRE_SOURCE):
>> +     @$(call targetinfo)
>> +     wget --no-cookies --header "Cookie: oraclelicense=accept-securebackup-cookie" $(ORACLE_JAVA7_JRE_URL) -P $(SRCDIR)/
>
> No, this is more complex. I need to think about how to handle this
> correctly.
>

Yes it's more complex, but right now it's the only way I know to
download it automatically. Suggestions to change are welcome :)

Should I put up a new patch with the changes mentioned here, and the rest?

Thanks :)
-- 
Mvh. / Kind regards
Martin Hejnfelt

-- 
ptxdist mailing list
ptxdist@pengutronix.de