Re: [ptxdist] [oracle java7 jre 1/1] Added Oracles Java 7 JRE

[Martin Hejnfelt <mh@newtec.dk>]

Hi Michael,

2015-01-08 12:58 GMT+01:00 Michael Olbrich <m.olbrich@pengutronix.de>:
>
> Any reason to use java7 and not java8?

Only reason is that I am developing for Java 7, and want to keep the
compatibility (or at least not introduce any issues, simply for
versioning). In my opinion, you should have both if anything.

>
>> +config ORACLE_JAVA7_JRE_TARGET_PREFIX
>> +     string
>> +     depends on ORACLE_JAVA7_JRE
>> +     default "/usr/lib/jvm"
>> +     prompt "PREFIX for JRE 7"
>> +     help
>> +       Where should the JRE be installed.
>
> Do we need this? I think we can just hardcode this path.
>

I agree, I'll change that.

>> +
>> +# ----------------------------------------------------------------------------
>> +# Get
>> +# ----------------------------------------------------------------------------
>> +
>> +$(ORACLE_JAVA7_JRE_SOURCE):
>> +     @$(call targetinfo)
>> +     wget --no-cookies --header "Cookie: oraclelicense=accept-securebackup-cookie" $(ORACLE_JAVA7_JRE_URL) -P $(SRCDIR)/
>
> No, this is more complex. I need to think about how to handle this
> correctly.
>

Yes it's more complex, but right now it's the only way I know to
download it automatically. Suggestions to change are welcome :)

Should I put up a new patch with the changes mentioned here, and the rest?

Thanks :)
-- 
Mvh. / Kind regards
Martin Hejnfelt

-- 
ptxdist mailing list
ptxdist@pengutronix.de