Re: [ptxdist] [PATCH] networkmanager: Version bump 1.30.4 to 1.44.2

[Lars Pedersen <lapeddk@gmail.com>]

On Tue, 28 Nov 2023 at 14:26, Michael Olbrich <m.olbrich@pengutronix.de> wrote:
>
> On Tue, Nov 28, 2023 at 02:10:59PM +0100, Lars Pedersen wrote:
> > On Tue, 28 Nov 2023 at 09:31, Michael Olbrich <m.olbrich@pengutronix.de> wrote:
> > >
> > > On Tue, Nov 21, 2023 at 08:29:17AM +0100, Lars Pedersen wrote:
> > > > dnssec_trigger and iptables configure options has been removed
> > > >
> > > > select PPP_MS_CHAP if NETWORKMANAGER_PPP is enabled to fix compile error:
> > > >   ../NetworkManager-1.44.2/src/core/ppp/nm-pppd-compat.c:50:10: fatal
> > > >   error: pppd/chap_ms.h: No such file or directory
> > > >      50 | #include <pppd/chap_ms.h>
> > > >
> > > > Signed-off-by: Lars Pedersen <lapeddk@gmail.com>
> > > > ---
> > > > Version 1.30.4 was getting pretty old and with this patch it will match
> > > > the one in Fedora 39. Surprisingly no major changes in configure
> > > > options.
> > > >
> > > > Note: Updating ppp to version 2.5.0 seemed pretty straight forward, but I
> > > > ran into issue https://github.com/ppp-project/ppp/issues/419. I'll try
> > > > to send a ppp patch when 2.5.1 is released.
> > >
> > > Hmmm, building fails with:
> > >
> > > FAILED: data/org.freedesktop.NetworkManager.policy
> > > .../sysroot-host/usr/bin/meson --internal msgfmthelper --msgfmt=.../sysroot-host/usr/bin/msgfmt data/org.freedesktop.NetworkManager.policy.in data/org.freedesktop.NetworkManager.policy xml .../build-target/NetworkManager-1.44.2/po
> > > .../sysroot-host/usr/bin/msgfmt: cannot locate ITS rules for data/org.freedesktop.NetworkManager.policy.in
> > >
> > > We're not selecting HOST_GETTEXT, so I'm guessing, msgfmt is found anyways
> > > even though it should not be used. But I've not looked any closer.
> > >
> > > Michael
> >
> > Hmm. We can't get the same error in our setup (ptxdist 2023.06.0).
> >
> > grep NETWORKMANAGER ptxconfig
> > PTXCONF_NETWORKMANAGER=y
> > PTXCONF_NETWORKMANAGER_NM_ONLINE=y
> > # PTXCONF_NETWORKMANAGER_NMTUI is not set
> > PTXCONF_NETWORKMANAGER_SYSTEMD_UNIT=y
> > # PTXCONF_NETWORKMANAGER_WIRELESS is not set
> > PTXCONF_NETWORKMANAGER_NMCLI=y
> > PTXCONF_NETWORKMANAGER_WWAN=y
> > PTXCONF_NETWORKMANAGER_PPP=y
> > # PTXCONF_NETWORKMANAGER_CONCHECK is not set
> > # PTXCONF_NETWORKMANAGER_EXAMPLES is not set
> > # PTXCONF_NETWORKMANAGER_POLKIT is not set
> > # PTXCONF_NETWORKMANAGER_MORE_LOGGING is not set
> > # PTXCONF_NETWORKMANAGER_INTROSPECTION is not set
> > # PTXCONF_NETWORKMANAGER_FORTISSLVPN is not set
> > # PTXCONF_NETWORKMANAGER_OPENVPN is not set
>
> It's my build everything BSP.
> All NETWORKMANAGER* options are enabled.
>
> > And we have tried enabling and disabling the following:
> >
> > # PTXCONF_HOST_GETTEXT
>
> This is enabled and was built before networkmanager.
>
> > # PTXCONF_GETTEXT
>
> Enabled and it was built before networkmanager, but I expect that this does
> not make a difference.
>
> > # PTXCONF_POLKIT
>
> This is a dependency with PTXCONF_NETWORKMANAGER_POLKIT enabled, so it's
> build before networkmanager.
>
> > What kind of networkmanager configuration are you testing?
>
> Michael

Hi.

We have reproduced the error and it looks like polkit is the issue.

I guess that we should just set it to broken for now like this (we
don't use this feature):

 config NETWORKMANAGER_POLKIT
        bool
+       depends on BROKEN
        prompt "polkit support"

/Lars Pedersen

>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |