mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Lars Pedersen <lapeddk@gmail.com>
To: Roland Hieber <rhi@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 4/4] python3-snmpclitools: new package
Date: Mon, 12 Jul 2021 12:34:11 +0200
Message-ID: <CAKd8=GuX_4byV3_5-TqhvF6QTvsAmG+1_PW=1-1B-1g39ZBXfQ@mail.gmail.com> (raw)
In-Reply-To: <20210707140139.jo5uvhp5b6vmabfo@pengutronix.de>

Hi. Thanks for the feedback.

On Wed, 7 Jul 2021 at 16:01, Roland Hieber <rhi@pengutronix.de> wrote:
>
> On Mon, Jul 05, 2021 at 11:33:50AM +0200, Lars Pedersen wrote:
> > This is a collection of command-line SNMP tools written in pure-Python.
> > This package depends on python3-pysnmp
> >
> > Signed-off-by: Lars Pedersen <lapeddk@gmail.com>
> > ---
> >  rules/python3-snmpclitools.in   |  9 ++++++
> >  rules/python3-snmpclitools.make | 56 +++++++++++++++++++++++++++++++++
> >  2 files changed, 65 insertions(+)
> >  create mode 100644 rules/python3-snmpclitools.in
> >  create mode 100644 rules/python3-snmpclitools.make
> >
> > diff --git a/rules/python3-snmpclitools.in b/rules/python3-snmpclitools.in
> > new file mode 100644
> > index 000000000..369b2bd65
> > --- /dev/null
> > +++ b/rules/python3-snmpclitools.in
> > @@ -0,0 +1,9 @@
> > +## SECTION=python3
> > +
> > +config PYTHON3_SNMPCLITOOLS
> > +     tristate
> > +     select PYTHON3
> > +     select PYTHON3_PYSNMP
> > +     prompt "snmpclitools"
> > +     help
> > +       This is a collection of command-line SNMP tools written in pure-Python
> > diff --git a/rules/python3-snmpclitools.make b/rules/python3-snmpclitools.make
> > new file mode 100644
> > index 000000000..050373add
> > --- /dev/null
> > +++ b/rules/python3-snmpclitools.make
> > @@ -0,0 +1,56 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2021 by Lars Pedersen <lapeddk@gmail.com>
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_PYTHON3_SNMPCLITOOLS) += python3-snmpclitools
> > +
> > +#
> > +# Paths and names
> > +#
> > +PYTHON3_SNMPCLITOOLS_VERSION := 0.6.4
> > +PYTHON3_SNMPCLITOOLS_MD5     := 132b100f5e7b80715e6c1d424e89687c
> > +PYTHON3_SNMPCLITOOLS         := snmpclitools-$(PYTHON3_SNMPCLITOOLS_VERSION)
> > +PYTHON3_SNMPCLITOOLS_SUFFIX  := tar.gz
> > +PYTHON3_SNMPCLITOOLS_URL     := $(call ptx/mirror-pypi, snmpclitools, $(PYTHON3_SNMPCLITOOLS).$(PYTHON3_SNMPCLITOOLS_SUFFIX))
> > +PYTHON3_SNMPCLITOOLS_SOURCE  := $(SRCDIR)/$(PYTHON3_SNMPCLITOOLS).$(PYTHON3_SNMPCLITOOLS_SUFFIX)
> > +PYTHON3_SNMPCLITOOLS_DIR     := $(BUILDDIR)/$(PYTHON3_SNMPCLITOOLS)
> > +PYTHON3_SNMPCLITOOLS_LICENSE := BSD-2pick
>
> No LICENSE.rst in this one…? Or any license statements in source files?

I have missed the LICENSE file. I'll send a new patch.

/Lars Pedersen

>
>  - Roland
>
> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +PYTHON3_SNMPCLITOOLS_CONF_TOOL       := python3
> > +PYTHON3_SNMPCLITOOLS_MAKE_OPT        := install_scripts
> > +
> > +# ----------------------------------------------------------------------------
> > +# Target-Install
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/python3-snmpclitools.targetinstall:
> > +     @$(call targetinfo)
> > +
> > +     @$(call install_init, python3-snmpclitools)
> > +     @$(call install_fixup, python3-snmpclitools,PRIORITY,optional)
> > +     @$(call install_fixup, python3-snmpclitools,SECTION,base)
> > +     @$(call install_fixup, python3-snmpclitools,AUTHOR,"Lars Pedersen <lapeddk@gmail.com>")
> > +     @$(call install_fixup, python3-snmpclitools,DESCRIPTION,missing)
> > +
> > +     @$(call install_glob, python3-snmpclitools, 0, 0, -, \
> > +             $(PYTHON3_SITEPACKAGES),, *.py)
> > +
> > +     @$(call install_glob,python3-snmpclitools, 0, 0, -, \
> > +             /usr/bin/,*.py,)
> > +
> > +     @$(call install_finish, python3-snmpclitools)
> > +
> > +     @$(call touch)
> > +
> > +# vim: syntax=make
> > --
> > 2.31.1
> >
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> >
>
> --
> Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
> Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2021-07-12 10:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05  9:33 [ptxdist] [PATCH 1/4] python3-pyasn1: " Lars Pedersen
2021-07-05  9:33 ` [ptxdist] [PATCH 2/4] python3-pysmi: " Lars Pedersen
2021-07-05  9:33 ` [ptxdist] [PATCH 3/4] python3-pysnmp: " Lars Pedersen
2021-07-05  9:33 ` [ptxdist] [PATCH 4/4] python3-snmpclitools: " Lars Pedersen
2021-07-07 14:01   ` Roland Hieber
2021-07-12 10:34     ` Lars Pedersen [this message]
2021-07-07 14:00 ` [ptxdist] [PATCH 1/4] python3-pyasn1: " Roland Hieber
2021-07-12 10:30   ` Lars Pedersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKd8=GuX_4byV3_5-TqhvF6QTvsAmG+1_PW=1-1B-1g39ZBXfQ@mail.gmail.com' \
    --to=lapeddk@gmail.com \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mailarchive of the ptxdist mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.ptxdist.org/ptxdist/0 ptxdist/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ptxdist ptxdist/ https://lore.ptxdist.org/ptxdist \
		ptxdist@pengutronix.de
	public-inbox-index ptxdist

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git