From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <lapeddk@gmail.com>) id 1iZXyj-0000XL-OG
 for ptxdist@pengutronix.de; Tue, 26 Nov 2019 11:21:54 +0100
Received: by mail-qv1-xf43.google.com with SMTP id v16so7026793qvq.6
 for <ptxdist@pengutronix.de>; Tue, 26 Nov 2019 02:21:53 -0800 (PST)
MIME-Version: 1.0
References: <20191118124538.223808-1-lapeddk@gmail.com>
 <20191119124937.274447-1-lapeddk@gmail.com>
 <20191125065330.GC14948@pengutronix.de>
In-Reply-To: <20191125065330.GC14948@pengutronix.de>
From: Lars Pedersen <lapeddk@gmail.com>
Date: Tue, 26 Nov 2019 11:21:41 +0100
Message-ID: <CAKd8=GuWS_NzYD8Q914QyR0uEJMEPJ8j+mPq4crsJ_qs+MLgsQ@mail.gmail.com>
Subject: Re: [ptxdist] [PATCH v2] strongswan: Version bump 5.6.1 -> 5.8.1
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

Thanks for the review.

On Mon, 25 Nov 2019 at 07:53, Michael Olbrich <m.olbrich@pengutronix.de> wrote:
>
> > -     @$(call install_lib, strongswan, 0, 0, 0644, libcharon)
> > -     @$(call install_lib, strongswan, 0, 0, 0644, libstrongswan)
> > +     @$(call install_tree, strongswan, 0, 0, -, /usr/bin)
> > +     @$(call install_glob, strongswan, 0, 0, -, /usr/lib,,*.la)
> > +     @$(call install_tree, strongswan, 0, 0, -, /usr/libexec)
> > +     @$(call install_tree, strongswan, 0, 0, -, /usr/sbin)
>
> No, we deliberately install the files explicitly. For shared libraries,
> this ensures that only the necessary links are installed.
> For all other files, this makes sure that we notice issues with the build
> configuration.
>
> Also, my check scripts noticed, that /usr/libexec/ipsec/xfrmi uses
> libstrongswan-kernel-netlink.so but is missing the correct rpath for this.
> It's in /usr/lib/plugins so not found by default.
>
> This can happen in ptxdist because we do tricks with the rpath to avoid
> paths to the build tree. Pulseaudio has the same problem. Take a look how
> it's handled there.
>

So basically you want the install_glob of libraries to be reverted
back into installing them all in a for loop using install_lib like
before?

I'm unsure about the rpath for xfrmi. The paths looks similar using
readelf if I compare it with the starter executable in the same dir.
What does your script output? The xfrmi is a new executable in
strongswan for policy based routing.

$readelf -a xfrmi
...
Dynamic section at offset 0x1e38 contains 32 entries:
  Tag        Type                         Name/Value
 0x00000001 (NEEDED)                     Shared library:
[libstrongswan-kernel-netlink.so]
 0x00000001 (NEEDED)                     Shared library: [libstrongswan.so.0]
 0x00000001 (NEEDED)                     Shared library: [libcharon.so.0]
 0x00000001 (NEEDED)                     Shared library: [libc.so.6]
 0x00000001 (NEEDED)                     Shared library: [ld-linux.so.3]
...

/Lars Pedersen

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de