From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 14 Jul 2025 18:30:30 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ubM4U-00HSKG-0Q for lore@lore.pengutronix.de; Mon, 14 Jul 2025 18:30:30 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ubM4T-00084q-VZ; Mon, 14 Jul 2025 18:30:29 +0200 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ubM47-00080N-PX for ptxdist@pengutronix.de; Mon, 14 Jul 2025 18:30:08 +0200 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-749248d06faso3764820b3a.2 for ; Mon, 14 Jul 2025 09:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752510606; x=1753115406; darn=pengutronix.de; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SJDAkVlzRAzdla/WqbJN+as88PGxoFoDPX+1bcJ9tvQ=; b=RKeNF3yjEVXWA4hPPsm2ZruC7Cm7oWrt19ebYtuMu3kuAdKJr0Y4gwRPy9wZT75Otm eBU4xE2rM5T9mntX/Vaodm0zu3Y0VNICJrq1w8//xPRhoPvyCn/CGGcLaBs7ZOSkKCSV R/P9YWIFCWjtO3i2Jl8+B52Mo/fIaTrfBdqCdvmZulum2rXG80Fp5SHbT7uj5fxv7XK1 qc3csVfYMoFZ449stlRnjizB46trMWDCWO4aa7Au2hRZPyvIBPeA8VsgWvh0GehQeMI6 Xz8o/CDiQWbaWP5wbDDf5J2DQAm+7qUDRza8v5vIZYiLuUagCDClUOKXRbthq4nBvci8 ZmnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752510606; x=1753115406; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SJDAkVlzRAzdla/WqbJN+as88PGxoFoDPX+1bcJ9tvQ=; b=dAmX3qVXDvyWExckFTqKrIKshHBJ7PSZ7Fuy52eayv6vutFggCYwX/1MqMs4axJpX/ YOrMI87ynwOWQG8uQx8Toh3ogTSnN/xd7bHbRVD61mfEjb6Jgbe89YaeHm/MYz+cOmgv 7rrq8xmoEqRtUQ1+IFgSuhbwB88kfDaDhW1qQHI30JdXEFfP77rr3wVbQdCZC33lLiiI Bq38doRNNYspYIp0KYYCwm9ZD5r197UwZkmWS9dU/p/MCI+/uD7093/1A+uyAGTprWH/ CyXty50Yzk4q4FkNuGfla/LCSYls4HRO8oJhFTkfLSTKTGvqeHVW016GjLxcfM1j8qKd 1JIA== X-Gm-Message-State: AOJu0Yyo5QAgJ9nGcGmfAYjtpiCElDZNNkaX5JAHiQW6ge2c8AHdjCwv zClCjDF5vKWZM9GjVIw8A5o6sW4mdu26OldZL/ogyTTQyNp/OwwZGY2mIMqkZb9IeT88XEBLaLp WxQXnH2OE1+LwwRcQNADE0Aul/sylXXA= X-Gm-Gg: ASbGncsvNkqBox6+PMT5QrmyRxFoKDCBqn6qPo7trSzsltQYL0qNlqVs8QvX8gh/ueh vEamji7Rup6qyT/DEn67RN1aFNmVJ3L4wrJ94BpWlUB2btiBDnWfSUsIGf1DfNoCS1JtDnTkHDy REXobxcCwvQKG44X06P/JKtNOIFuV/SpGf0Ech82RqMg4f3gPQLx4TwQRO8vKHPcyfj/It76pUO Ko59nE= X-Google-Smtp-Source: AGHT+IEaYlfCrDSGE17rJljg7gTJdcXAtLin7YASpl+FoSG1qKLgIv+yUCK1tH36Pm/bc2rLrgfSXZsyS7pDjZ2IuK4= X-Received: by 2002:a05:6a00:2e9b:b0:748:de30:d01 with SMTP id d2e1a72fcca58-74ee167c6cemr17813024b3a.10.1752510605422; Mon, 14 Jul 2025 09:30:05 -0700 (PDT) MIME-Version: 1.0 References: <20250714073142.3772107-1-lapeddk@gmail.com> <20250714073142.3772107-2-lapeddk@gmail.com> In-Reply-To: From: Lars Pedersen Date: Mon, 14 Jul 2025 18:29:53 +0200 X-Gm-Features: Ac12FXzq6wv0hiZzdVaZpeJPN5e0rS68d7GzU6GNMqDWNMDIXYLtgrhvmLSde28 Message-ID: To: Markus Heidelberg Content-Type: text/plain; charset="UTF-8" X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v2 2/2] libgpiod: version bump 2.1.3 -> 2.2.2 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: "ptxdist@pengutronix.de" Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi. On Mon, 14 Jul 2025 at 15:58, Markus Heidelberg wrote: > > On Mon, Jul 14, 2025 at 09:31:42AM +0200, Lars Alex Pedersen wrote: > > * Add new options to install the dbus daemon with and without systemd. > > * Add gpio in group > > * Add gpio-manager user and group > > * Python binding now requires host pybuild and pip for build and install > > * Removed ac_cv_prog_has_python_config line in rule, since it has been > > fixed in this release > > * Configure options updated and reordered to match configure helper > > > > https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/tree/NEWS?h=v2.2.2 > > > > Signed-off-by: Lars Alex Pedersen > > --- > > projectroot/etc/group | 2 ++ > > projectroot/etc/passwd | 1 + > > rules/libgpiod.in | 27 ++++++++++++++++++++++++--- > > rules/libgpiod.make | 29 ++++++++++++++++++++++++----- > > 4 files changed, 51 insertions(+), 8 deletions(-) > > > diff --git a/rules/libgpiod.in b/rules/libgpiod.in > > index 94bff5164..43f813fa8 100644 > > --- a/rules/libgpiod.in > > +++ b/rules/libgpiod.in > > @@ -3,9 +3,14 @@ > > menuconfig LIBGPIOD > > tristate > > prompt "libgpiod " > > - select HOST_SYSTEM_PYTHON3 > > - select GCCLIBS_CXX if LIBGPIOD_CXX > > - select PYTHON3 if LIBGPIOD_PYTHON3 > > + select HOST_SYSTEM_PYTHON3 if LIBGPIOD_PYTHON3 > > + select HOST_PYTHON3_PYBUILD if LIBGPIOD_PYTHON3 > > + select HOST_PYTHON3_PIP if LIBGPIOD_PYTHON3 > > Python bindings compile and work now after this local adaption of > bindings/python/Makefile as proposed in your last mail: > > $(PYTHON) -m build --skip-dependency-check --wheel --no-isolation > > I don't know either if that's the right solution. > > > +config LIBGPIOD_DBUS_DAEMON > > + bool > > + prompt "Install dbus daemon" > > + select LIBGPIOD_TOOLS > > This is wrong because PTXCONF_LIBGPIOD_TOOLS controls > --enable/--disable-tools which is used for the tools/ directory only. > > > diff --git a/rules/libgpiod.make b/rules/libgpiod.make > > index 6272333b5..cf4656150 100644 > > --- a/rules/libgpiod.make > > +++ b/rules/libgpiod.make > > @@ -63,6 +67,8 @@ LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIOGET) += gpioget > > LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIOSET) += gpioset > > LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIOMON) += gpiomon > > LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIONOTIFY) += gpionotify > > +LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_DBUS_DAEMON) += gpio-manager > > +LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_DBUS_DAEMON) += gpiocli > > > > # ---------------------------------------------------------------------------- > > # Target-Install > > @@ -84,6 +90,19 @@ $(STATEDIR)/libgpiod.targetinstall: > > /usr/bin/$$tool); \ > > done > > > > +ifdef PTXCONF_LIBGPIOD_DBUS_DAEMON > > + @$(call install_tree, libgpiod, 0, 0, -, /usr/share/dbus-1/interfaces) > > + @$(call install_tree, libgpiod, 0, 0, -, /etc/dbus-1/system.d) > > + @$(call install_lib, libgpiod, 0, 0, 0644, libgpiodbus) > > + @$(call install_lib, libgpiod, 0, 0, 0644, libgpiod-glib) > > +endif > > +ifdef PTXCONF_LIBGPIOD_DBUS_DAEMON_SYSTEMD > > + @$(call install_tree, libgpiod, 0, 0, -, /usr/lib/udev/rules.d) > > + @$(call install_alternative, libgpiod, 0, 0, 0644, \ > > + /usr/lib/systemd/system/gpio-manager.service) > > + @$(call install_link, libgpiod, ../gpio-manager.service, \ > > + /usr/lib/systemd/system/multi-user.target.wants/gpio-manager.service) > > +endif > > License information is still missing. > It would also be incomplete with active PTXCONF_LIBGPIOD_TOOLS part. Thanks for the review. In my mind it was a tool, but I now see what you mean. Good to see that python binding now seems to work. I'll guess third time is the charm :) /Lars Pedersen > > Markus