From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 16 Jul 2025 18:02:47 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uc4al-000XWS-1L for lore@lore.pengutronix.de; Wed, 16 Jul 2025 18:02:47 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uc4al-00056d-87; Wed, 16 Jul 2025 18:02:47 +0200 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1uc4aN-00052I-0V for ptxdist@pengutronix.de; Wed, 16 Jul 2025 18:02:24 +0200 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-747e41d5469so106070b3a.3 for ; Wed, 16 Jul 2025 09:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752681741; x=1753286541; darn=pengutronix.de; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4nGkOPierxsRH8/KLsH/JtC/i3XsKU0NBlXaXrvWeko=; b=VSlfUJoHXLadj7csjHHJTQQ6s8IxfiWKdqBTmptQFMCo7WsMavCuDUrcwl+F7g6y1P VCiggtpnY+XJUe2/GsywW++LbclKibLldqz6fcdJViHE8pfvJQ5TL2HKM3SKBhJIdBCT YbEPiF/y8d08arOKhUTG6bSAaqNfdn72rOHPYTJBLc30O9W1nVSLq0ZFoUNGdvbemWUJ LfgLqVJg7FjFKfWsGuCC7GjdCDQvmXIMpZm5mjCe5V4wWn4qvrMMFasfjIviJvTEx5JX /JH9OlfoaAafneCa7jiEBnr/xh0TN6eAoQYPiTIz930aZylnSWVgWvopix6PHgoE7E+j RFfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752681741; x=1753286541; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4nGkOPierxsRH8/KLsH/JtC/i3XsKU0NBlXaXrvWeko=; b=qG9m+oCNWhqtyFa7kh8jWL7YPQKrzyxSvMBsto6luYuuMXun5SDFhR7Jxk85Tw0uib vWuTvoXEO2nSunxrjKI12I769EO8AIwu503+vb498cAPKBCloeGeoIT/Vjy/q7Y8dI1u aSQxvLUabYslt6zigBMnw7Fu96owWynuHZysszXzruDjO49z6qUti3Sgyl5FoKn2C8Dr KZPYJnSax5OicSpcSfouw9YwolBPUoRp9VHStm3c9cx9yNCJG3YDobBzXgE2K4bWyYgk m//nuEO9kO/NLN0ZcO7Zzrgjqrmx1kxqBAjEtQs17+mysM81d0GG6Z2jZEyozT3+b4qu BIHg== X-Gm-Message-State: AOJu0Yxxu84jH3s+AYHa+R3mYfDVibzRybqpNKKjtSMyMZWfmzarIEkS QXDmsBQFcnfEEyaZ7Rh1kex918ypidw7HdnMDut5RgJjgt0PkNs83e9/rNLtMX5q384DCGSxG48 mp50TqOe2vJp0K/4sSgapHvdNSpKm22puq0zqTR2sDg== X-Gm-Gg: ASbGnctEbctG1bNIJJ+5x3EiVxjrUndecZ2Ctr2qI5Fk3efhvel0NHZq7AbaxAwNW2X LNB+MiA6tYkFBljHTs5Qoc7o3Um/9oGSJXjdr0o8kiiIz2Z8wQEl0IPdNfz48AyRXRwrWINbrRO SFq3OBQ5GJK+uxBS2y5uWb9zlFyUoysVXGca4yK2KgFQrkyR/MQgztgbHmm2UHar1Q1riN2rofH xdvvjE= X-Google-Smtp-Source: AGHT+IFG9HGJrrFL/dqtuGb1yq0XkZXbQkvZ4gpVZcAF3rcHuorgv5i4vabfnayJKRI6SLqxeZ1DqgAoPeVb+aHuvwQ= X-Received: by 2002:a05:6a20:4324:b0:203:bb3b:5f1d with SMTP id adf61e73a8af0-23810d53c0amr4869624637.6.1752681740939; Wed, 16 Jul 2025 09:02:20 -0700 (PDT) MIME-Version: 1.0 References: <20250715135327.753766-1-lapeddk@gmail.com> <20250715135327.753766-2-lapeddk@gmail.com> In-Reply-To: From: Lars Pedersen Date: Wed, 16 Jul 2025 18:02:09 +0200 X-Gm-Features: Ac12FXxJJHZvk83FmcqyFAS77l8m1kym1jlZPHlvSUODVh6xLvV_A9BlB4o-XIM Message-ID: To: Markus Heidelberg Content-Type: text/plain; charset="UTF-8" X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v3 2/2] libgpiod: version bump 2.1.3 -> 2.2.2 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: "ptxdist@pengutronix.de" Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi. On Wed, 16 Jul 2025 at 15:58, Markus Heidelberg wrote: > > On Tue, Jul 15, 2025 at 03:53:27PM +0200, Lars Alex Pedersen wrote: > > * Add new options to install the dbus daemon with and without systemd. > > * Add gpio in group > > * Add gpio-manager user and group > > * Python binding now requires host pybuild and pip for build and > > install, together with a patch to get the right build options > > * Removed ac_cv_prog_has_python_config line in rule, since it has been > > fixed in this release > > * Configure options updated and reordered to match configure helper > > * New option --disable-introspection is removed by autogen.sh > > > > https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/tree/NEWS?h=v2.2.2 > > > > Signed-off-by: Lars Alex Pedersen > > --- > > ...1-Add-ptxdist-python-compile-options.patch | 22 ++++++++ > > patches/libgpiod-2.2.2/autogen.sh | 1 + > > patches/libgpiod-2.2.2/series | 4 ++ > > Python bindings can be built now without local adaption. Great. > > > projectroot/etc/group | 2 + > > projectroot/etc/passwd | 1 + > > rules/libgpiod.in | 27 ++++++++-- > > rules/libgpiod.make | 53 ++++++++++++++----- > > 7 files changed, 94 insertions(+), 16 deletions(-) > > create mode 100644 patches/libgpiod-2.2.2/0001-Add-ptxdist-python-compile-options.patch > > create mode 120000 patches/libgpiod-2.2.2/autogen.sh > > create mode 100644 patches/libgpiod-2.2.2/series > > > diff --git a/rules/libgpiod.make b/rules/libgpiod.make > > index 6272333b5..6110130f2 100644 > > --- a/rules/libgpiod.make > > +++ b/rules/libgpiod.make > > > @@ -28,9 +28,18 @@ LIBGPIOD_LICENSE_FILES := \ > > file://LICENSES/GPL-2.0-only.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ > > file://LICENSES/Linux-syscall-note.txt;md5=6b0dff741019b948dfe290c05d6f361c > > > > +ifdef PTXCONF_LIBGPIOD_DBUS_DAEMON > > +LIBGPIOD_LICENSE += AND GPL-2.0-or-later AND CC-BY-SA-4.0 AND CC0-1.0 > > +LIBGPIOD_LICENSE_FILES += \ > > + file://LICENSES/GPL-2.0-or-later.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ > > + file://LICENSES/CC-BY-SA-4.0.txt;md5=fba3b94d88bfb9b81369b869a1e9a20f \ > > + file://LICENSES/CC0-1.0.txt;md5=65d3616852dbf7b1a6d4b53b00626032 > > CC0-1.0 is only used for gpio-manager.service and 90-gpio.rules, so it > should be dependent on PTXCONF_LIBGPIOD_DBUS_DAEMON_SYSTEMD. > However, if installing rules files independently of systemd (see below), > license selection would be correct. Yes you are right. I need to split it an extra time. > > > -LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIODETECT) += gpiodetect > > -LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIOINFO) += gpioinfo > > -LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIOGET) += gpioget > > -LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIOSET) += gpioset > > -LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIOMON) += gpiomon > > -LIBGPIOD_TOOLS-$(PTXCONF_LIBGPIOD_GPIONOTIFY) += gpionotify > > +LIBGPIOD_BINS-$(PTXCONF_LIBGPIOD_GPIODETECT) += gpiodetect > > +LIBGPIOD_BINS-$(PTXCONF_LIBGPIOD_GPIOINFO) += gpioinfo > > +LIBGPIOD_BINS-$(PTXCONF_LIBGPIOD_GPIOGET) += gpioget > > +LIBGPIOD_BINS-$(PTXCONF_LIBGPIOD_GPIOSET) += gpioset > > +LIBGPIOD_BINS-$(PTXCONF_LIBGPIOD_GPIOMON) += gpiomon > > +LIBGPIOD_BINS-$(PTXCONF_LIBGPIOD_GPIONOTIFY) += gpionotify > > +LIBGPIOD_BINS-$(PTXCONF_LIBGPIOD_DBUS_DAEMON) += gpio-manager > > +LIBGPIOD_BINS-$(PTXCONF_LIBGPIOD_DBUS_DAEMON) += gpiocli > > > > # ---------------------------------------------------------------------------- > > # Target-Install > > @@ -79,11 +93,24 @@ $(STATEDIR)/libgpiod.targetinstall: > > > > @$(call install_lib, libgpiod, 0, 0, 0644, libgpiod) > > > > - @for tool in $(LIBGPIOD_TOOLS-y); do \ > > + @for tool in $(LIBGPIOD_BINS-y); do \ > > $(call install_copy, libgpiod, 0, 0, 0755, -, \ > > /usr/bin/$$tool); \ > > done > > Good idea to rename LIBGPIOD_TOOLS-* to avoid confusion with the slightly > unrelated PTXCONF_LIBGPIOD_TOOLS. > > > +ifdef PTXCONF_LIBGPIOD_DBUS_DAEMON > > + @$(call install_tree, libgpiod, 0, 0, -, /usr/share/dbus-1/interfaces) > > + @$(call install_tree, libgpiod, 0, 0, -, /etc/dbus-1/system.d) > > + @$(call install_lib, libgpiod, 0, 0, 0644, libgpiodbus) > > + @$(call install_lib, libgpiod, 0, 0, 0644, libgpiod-glib) > > +endif > > +ifdef PTXCONF_LIBGPIOD_DBUS_DAEMON_SYSTEMD > > + @$(call install_tree, libgpiod, 0, 0, -, /usr/lib/udev/rules.d) > > Shouldn't udev rules (90-gpio.rules in this case) be installed > independently of systemd? This would also be how nearly all existing > packages containing udev rules files behave. The 90-gpio.rules file is only installed with systemd: ---- # SPDX-License-Identifier: GPL-2.0-or-later # SPDX-FileCopyrightText: 2022-2023 Bartosz Golaszewski dbusdir = $(sysconfdir)/dbus-1/system.d/ dist_dbus_DATA = io.gpiod1.conf if WITH_SYSTEMD dist_systemdsystemunit_DATA = gpio-manager.service udevdir = $(libdir)/udev/rules.d/ dist_udev_DATA = 90-gpio.rules endif --- > > Sorry for this late feedback. I only had a deeper look into the dbus > part after adaption of the license information. So maybe v4 :) Yes v4 :) /Lars Pedersen > > > + @$(call install_alternative, libgpiod, 0, 0, 0644, \ > > + /usr/lib/systemd/system/gpio-manager.service) > > + @$(call install_link, libgpiod, ../gpio-manager.service, \ > > + /usr/lib/systemd/system/multi-user.target.wants/gpio-manager.service) > > +endif > > Markus