From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 28 Nov 2023 14:11:33 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r7xsC-00C6Mg-2U for lore@lore.pengutronix.de; Tue, 28 Nov 2023 14:11:33 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1r7xsC-0000gt-Uf; Tue, 28 Nov 2023 14:11:32 +0100 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1r7xrr-0000ge-80; Tue, 28 Nov 2023 14:11:11 +0100 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a00b01955acso777821666b.1; Tue, 28 Nov 2023 05:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701177070; x=1701781870; darn=pengutronix.de; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hXcO5WxjmgBsqsJDVMFRh3L5gdFIRBY1YvlM1ZI7RPA=; b=FZXGjEUZtp4dy4g8t82jE4e89BxKojDRxbh1r5gePYdYIhBJRH1CSbs261wVuEe486 W6XdjDWeU3UvLNm5gdhQYJeAYnTAxrxUGXCXkcMcYevcNF1Qqkg4LlSaZMAxxs3DvBZe weuH+dW52BVhe15M8mgdvfxR3Bi/+Qgv+LhMKEm9J9CJals5afU+NSBUPpXyZI7OrsOe imdBovKpsIOMuvQOBksJyDxTDlPMpuLSC08jpMeTJX88RQDnvns0NBXYBg4w2FL3rWuM UlFFURDoghQhEBOW+9D/T+hlbP0b9gUNvi5q9/xym5xV4Pqgr2Q/josbGTEBlKVFhYaS y3HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701177070; x=1701781870; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hXcO5WxjmgBsqsJDVMFRh3L5gdFIRBY1YvlM1ZI7RPA=; b=V6bLCySJ/OMiTwFHf7tm924j8QP2IFwIQ9xYQLGT/vroBrvroHls2KulDX1F9CtjWQ 4I7FnJ0LkV254a2i6P3rscILFRaV153lYTQ2OykqGfy/klt7HuWgyuXrwBxL5jBYYUfr +j3KuyYCgMbIRtqgayI6xZyYHv7G9NbCt9oii7L5fXy2njsm6Mc8kUsm20x98SO//ZGY 69u2ENrkqaoqJmvTIi8A0mRnsaSMl2rogTvGZpwS7uD/MKHFmnXKDGut4as/OGKjQ+hp yHVZBQwjFS5BPczNu2Tm6VSNKfLnyWKqsF1xSV318TG8v/L95x97b8KTM71hEIDwmzuU t/ng== X-Gm-Message-State: AOJu0YwDp20yeerPDah961IZAfZvw+91BnOPP4VuKbSP+Ed9EonJVBlY HrlBg3ExH+KlFlu8QcsEjsI8gc2ADVAmEx4QcnZDrqzI5lE= X-Google-Smtp-Source: AGHT+IGmQLUji4PtVCXNMkPDKs7FNjQB6rpSt/u16otNMJlugexRg7khBXLTNqfkbwMjd1i6NG2H6A2T570N/J9aj0c= X-Received: by 2002:a17:906:9e0a:b0:9f5:994c:7d15 with SMTP id fp10-20020a1709069e0a00b009f5994c7d15mr7778519ejc.77.1701177070354; Tue, 28 Nov 2023 05:11:10 -0800 (PST) MIME-Version: 1.0 References: <20231121072917.28820-1-lapeddk@gmail.com> In-Reply-To: From: Lars Pedersen Date: Tue, 28 Nov 2023 14:10:59 +0100 Message-ID: To: m.olbrich@pengutronix.de Content-Type: text/plain; charset="UTF-8" X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=4.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] networkmanager: Version bump 1.30.4 to 1.44.2 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Tue, 28 Nov 2023 at 09:31, Michael Olbrich wrote: > > On Tue, Nov 21, 2023 at 08:29:17AM +0100, Lars Pedersen wrote: > > dnssec_trigger and iptables configure options has been removed > > > > select PPP_MS_CHAP if NETWORKMANAGER_PPP is enabled to fix compile error: > > ../NetworkManager-1.44.2/src/core/ppp/nm-pppd-compat.c:50:10: fatal > > error: pppd/chap_ms.h: No such file or directory > > 50 | #include > > > > Signed-off-by: Lars Pedersen > > --- > > Version 1.30.4 was getting pretty old and with this patch it will match > > the one in Fedora 39. Surprisingly no major changes in configure > > options. > > > > Note: Updating ppp to version 2.5.0 seemed pretty straight forward, but I > > ran into issue https://github.com/ppp-project/ppp/issues/419. I'll try > > to send a ppp patch when 2.5.1 is released. > > Hmmm, building fails with: > > FAILED: data/org.freedesktop.NetworkManager.policy > .../sysroot-host/usr/bin/meson --internal msgfmthelper --msgfmt=.../sysroot-host/usr/bin/msgfmt data/org.freedesktop.NetworkManager.policy.in data/org.freedesktop.NetworkManager.policy xml .../build-target/NetworkManager-1.44.2/po > .../sysroot-host/usr/bin/msgfmt: cannot locate ITS rules for data/org.freedesktop.NetworkManager.policy.in > > We're not selecting HOST_GETTEXT, so I'm guessing, msgfmt is found anyways > even though it should not be used. But I've not looked any closer. > > Michael Hmm. We can't get the same error in our setup (ptxdist 2023.06.0). grep NETWORKMANAGER ptxconfig PTXCONF_NETWORKMANAGER=y PTXCONF_NETWORKMANAGER_NM_ONLINE=y # PTXCONF_NETWORKMANAGER_NMTUI is not set PTXCONF_NETWORKMANAGER_SYSTEMD_UNIT=y # PTXCONF_NETWORKMANAGER_WIRELESS is not set PTXCONF_NETWORKMANAGER_NMCLI=y PTXCONF_NETWORKMANAGER_WWAN=y PTXCONF_NETWORKMANAGER_PPP=y # PTXCONF_NETWORKMANAGER_CONCHECK is not set # PTXCONF_NETWORKMANAGER_EXAMPLES is not set # PTXCONF_NETWORKMANAGER_POLKIT is not set # PTXCONF_NETWORKMANAGER_MORE_LOGGING is not set # PTXCONF_NETWORKMANAGER_INTROSPECTION is not set # PTXCONF_NETWORKMANAGER_FORTISSLVPN is not set # PTXCONF_NETWORKMANAGER_OPENVPN is not set And we have tried enabling and disabling the following: # PTXCONF_HOST_GETTEXT # PTXCONF_GETTEXT # PTXCONF_POLKIT What kind of networkmanager configuration are you testing? /Lars Pedersen > > > rules/networkmanager.in | 1 + > > rules/networkmanager.make | 6 ++---- > > 2 files changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/rules/networkmanager.in b/rules/networkmanager.in > > index e9af26729..8c5e8ad2e 100644 > > --- a/rules/networkmanager.in > > +++ b/rules/networkmanager.in > > @@ -24,6 +24,7 @@ menuconfig NETWORKMANAGER > > select POLKIT if NETWORKMANAGER_POLKIT > > select PPP if NETWORKMANAGER_PPP > > select PPP_PLUGINS if NETWORKMANAGER_PPP > > + select PPP_MS_CHAP if NETWORKMANAGER_PPP > > select READLINE if NETWORKMANAGER_NMCLI > > select SYSTEMD if NETWORKMANAGER_SYSTEMD_UNIT > > select UDEV > > diff --git a/rules/networkmanager.make b/rules/networkmanager.make > > index 9b47fadad..af310bd13 100644 > > --- a/rules/networkmanager.make > > +++ b/rules/networkmanager.make > > @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_NETWORKMANAGER) += networkmanager > > # > > # Paths and names > > # > > -NETWORKMANAGER_VERSION := 1.30.4 > > -NETWORKMANAGER_MD5 := 8ce53a38356864832f7f10ad46fcde27 > > +NETWORKMANAGER_VERSION := 1.44.2 > > +NETWORKMANAGER_MD5 := bd6c9cb0ecd0fb7f516cde7bf4dee3fb > > NETWORKMANAGER := NetworkManager-$(NETWORKMANAGER_VERSION) > > NETWORKMANAGER_SUFFIX := tar.xz > > NETWORKMANAGER_URL := $(call ptx/mirror, GNOME, NetworkManager/$(basename $(NETWORKMANAGER_VERSION))/$(NETWORKMANAGER).$(NETWORKMANAGER_SUFFIX)) > > @@ -47,7 +47,6 @@ NETWORKMANAGER_CONF_OPT = \ > > -Ddhcpcanon=false \ > > -Ddhcpcd=false \ > > -Ddnsmasq=/usr/sbin/dnsmasq \ > > - -Ddnssec_trigger=/bin/true \ > > -Ddocs=false \ > > -Debpf=false \ > > -Dfirewalld_zone=false \ > > @@ -55,7 +54,6 @@ NETWORKMANAGER_CONF_OPT = \ > > -Difcfg_rh=false \ > > -Difupdown=true \ > > -Dintrospection=$(call ptx/truefalse,PTXCONF_NETWORKMANAGER_INTROSPECTION) \ > > - -Diptables=/usr/sbin/iptables \ > > -Diwd=false \ > > -Dkernel_firmware_dir=/lib/firmware \ > > -Dld_gc=true \ > > -- > > 2.41.0 > > > > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |