* Re: [ptxdist] configure failed with sed version 4.2.2
[not found] <CAKNcqrgFfFzNuxhi8nJBXjoHq9Lmh8t6WFau_uA3gOQQax1H6A@mail.gmail.com>
@ 2014-07-29 13:20 ` Marc Kleine-Budde
2014-07-29 14:39 ` Kristof Verdonck
0 siblings, 1 reply; 6+ messages in thread
From: Marc Kleine-Budde @ 2014-07-29 13:20 UTC (permalink / raw)
To: Kristof Verdonck, ptxdist
[-- Attachment #1.1: Type: text/plain, Size: 1193 bytes --]
Hello Kristof,
thanks for your mail, please use the ptxdist mailinglist (Cc'ed) in the
future.
On 07/29/2014 03:08 PM, Kristof Verdonck wrote:
> I had a problem with the ptxdist configure script for checking the SED
> version.
Which version of ptxdist are you using?
> Apparently this is a known issue that hasn't been fixed yet.
> https://www.mail-archive.com/ptxdist@pengutronix.de/msg06717.html
I think the problem has been fixed with the patch:
2a89985 configure.ac: change regex for sed version
> I took the regular expression GLIBC used to check the SED version.
> I tested it with sed 3.02.80, 4.1.5, 4.2.1 and 4.2.2
> I thought you could use this.
>
> SED_VERSION=`$SED --version 2>/dev/null | $SED -n "s/^.*GNU sed[^0-9]*
> \([0-9]*\.[0-9.]*\).*$/\1/p"`
AFAIK we don't have any problems with sed since the above patch in
mainline, which is ptxdist-2013.01.0.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
[-- Attachment #2: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [ptxdist] configure failed with sed version 4.2.2
2014-07-29 13:20 ` [ptxdist] configure failed with sed version 4.2.2 Marc Kleine-Budde
@ 2014-07-29 14:39 ` Kristof Verdonck
2014-07-31 8:34 ` Marc Kleine-Budde
0 siblings, 1 reply; 6+ messages in thread
From: Kristof Verdonck @ 2014-07-29 14:39 UTC (permalink / raw)
To: ptxdist
[-- Attachment #1.1: Type: text/plain, Size: 1656 bytes --]
I'm using an ancient ptxdist, but that doesn't matter because I'm isolating
the SED-version check.
If I run the regex from
http://git.pengutronix.de/?p=ptxdist.git;a=blob;f=configure.ac;h=22c8df03a8c225514a3df7ba4c9fb29c515c3e24;hb=HEAD
sed --version 2>/dev/null | sed -ne "1
s/.*GNU.*\s\([[0-9\+\.]]\+\).*/\1/p" then
it returns empty, both with sed 4.2.1 and 4.2.2.
2014-07-29 15:20 GMT+02:00 Marc Kleine-Budde <mkl@pengutronix.de>:
> Hello Kristof,
>
> thanks for your mail, please use the ptxdist mailinglist (Cc'ed) in the
> future.
>
> On 07/29/2014 03:08 PM, Kristof Verdonck wrote:
> > I had a problem with the ptxdist configure script for checking the SED
> > version.
>
> Which version of ptxdist are you using?
>
> > Apparently this is a known issue that hasn't been fixed yet.
> > https://www.mail-archive.com/ptxdist@pengutronix.de/msg06717.html
>
> I think the problem has been fixed with the patch:
>
> 2a89985 configure.ac: change regex for sed version
>
> > I took the regular expression GLIBC used to check the SED version.
> > I tested it with sed 3.02.80, 4.1.5, 4.2.1 and 4.2.2
> > I thought you could use this.
> >
> > SED_VERSION=`$SED --version 2>/dev/null | $SED -n "s/^.*GNU sed[^0-9]*
> > \([0-9]*\.[0-9.]*\).*$/\1/p"`
>
> AFAIK we don't have any problems with sed since the above patch in
> mainline, which is ptxdist-2013.01.0.
>
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Industrial Linux Solutions | Phone: +49-231-2826-924 |
> Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
>
>
[-- Attachment #1.2: Type: text/html, Size: 2928 bytes --]
[-- Attachment #2: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] configure failed with sed version 4.2.2
2014-07-29 14:39 ` Kristof Verdonck
@ 2014-07-31 8:34 ` Marc Kleine-Budde
2014-07-31 14:53 ` Kristof Verdonck
0 siblings, 1 reply; 6+ messages in thread
From: Marc Kleine-Budde @ 2014-07-31 8:34 UTC (permalink / raw)
To: ptxdist
[-- Attachment #1.1: Type: text/plain, Size: 1001 bytes --]
On 07/29/2014 04:39 PM, Kristof Verdonck wrote:
> I'm using an ancient ptxdist, but that doesn't matter because I'm
> isolating the SED-version check.
>
> If I run the regex
> from http://git.pengutronix.de/?p=ptxdist.git;a=blob;f=configure.ac;h=22c8df03a8c225514a3df7ba4c9fb29c515c3e24;hb=HEAD
> sed --version 2>/dev/null | sed -ne "1 s/.*GNU.*\s\([[0-9\+\.]]\+\).*/\1/p"
> then it returns empty, both with sed 4.2.1 and 4.2.2.
Are you using the unmodified regex from the configure.ac in the shell?
Try this instead:
sed --version 2>/dev/null | \
sed -ne "1 s/.*GNU.*\s\([0-9\+\.]\+\).*/\1/p"
Note: '[' vs. '[[', as you have to quote '[' in configure.ac, as it's
processed by m4.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
[-- Attachment #2: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [ptxdist] configure failed with sed version 4.2.2
2014-07-31 8:34 ` Marc Kleine-Budde
@ 2014-07-31 14:53 ` Kristof Verdonck
0 siblings, 0 replies; 6+ messages in thread
From: Kristof Verdonck @ 2014-07-31 14:53 UTC (permalink / raw)
To: ptxdist
[-- Attachment #1.1: Type: text/plain, Size: 1200 bytes --]
You're absolutely right.
The double '[' got me.
2014-07-31 10:34 GMT+02:00 Marc Kleine-Budde <mkl@pengutronix.de>:
> On 07/29/2014 04:39 PM, Kristof Verdonck wrote:
> > I'm using an ancient ptxdist, but that doesn't matter because I'm
> > isolating the SED-version check.
> >
> > If I run the regex
> > from
> http://git.pengutronix.de/?p=ptxdist.git;a=blob;f=configure.ac;h=22c8df03a8c225514a3df7ba4c9fb29c515c3e24;hb=HEAD
> > sed --version 2>/dev/null | sed -ne "1
> s/.*GNU.*\s\([[0-9\+\.]]\+\).*/\1/p"
> > then it returns empty, both with sed 4.2.1 and 4.2.2.
>
> Are you using the unmodified regex from the configure.ac in the shell?
>
> Try this instead:
>
> sed --version 2>/dev/null | \
> sed -ne "1 s/.*GNU.*\s\([0-9\+\.]\+\).*/\1/p"
>
> Note: '[' vs. '[[', as you have to quote '[' in configure.ac, as it's
> processed by m4.
>
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Industrial Linux Solutions | Phone: +49-231-2826-924 |
> Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
>
[-- Attachment #1.2: Type: text/html, Size: 2293 bytes --]
[-- Attachment #2: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ptxdist] configure failed with sed version 4.2.2
@ 2013-01-07 14:19 Alexander Aring
2013-01-07 16:38 ` Marc Kleine-Budde
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Aring @ 2013-01-07 14:19 UTC (permalink / raw)
To: ptxdist
[-- Attachment #1.1: Type: text/plain, Size: 1376 bytes --]
Hello,
i am using archlinux with GNU sed version 4.2.2 which generate with 'sed
--version':
sed (GNU sed) 4.2.2
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html
>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by Jay Fenlason, Tom Lord, Ken Pizzini,
and Paolo Bonzini.
GNU sed home page: <http://www.gnu.org/software/sed/>.
General help using GNU software: <http://www.gnu.org/gethelp/>.
E-mail bug reports to: <bug-sed@gnu.org>.
Be sure to include the word ``sed'' somewhere in the ``Subject:'' field.
This will fail on sed version check in configure.ac:
SED_VERSION=`$SED --version 2>/dev/null | $SED -ne "s/.*version
\([[0-9\.]]*\)/\1/p"`
With command 'sed --version 2>/dev/null | sed -ne "s/.*version
\([[0-9\.]]*\)/\1/p"' I got following output:
"3 or later <http://gnu.org/licenses/gpl.html>."
and configure failed with:
checking sed version... configure: error: we need at least GNU sed 4.x
GNU sed gets version string from gnulib see
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/version-etc.c;hb=dbed1625626c6d6f271b715f87fd0930d8e68c2f
beginning at line 43.
I don't see a "version" substring there, maybe it isn't the best way to
match the sed version.
Regards
Alexander Aring
[-- Attachment #1.2: Type: text/html, Size: 2025 bytes --]
[-- Attachment #2: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] configure failed with sed version 4.2.2
2013-01-07 14:19 Alexander Aring
@ 2013-01-07 16:38 ` Marc Kleine-Budde
0 siblings, 0 replies; 6+ messages in thread
From: Marc Kleine-Budde @ 2013-01-07 16:38 UTC (permalink / raw)
To: ptxdist; +Cc: Alexander Aring
[-- Attachment #1.1: Type: text/plain, Size: 2476 bytes --]
On 01/07/2013 03:19 PM, Alexander Aring wrote:
> Hello,
>
> i am using archlinux with GNU sed version 4.2.2 which generate with 'sed
> --version':
>
> sed (GNU sed) 4.2.2
> Copyright (C) 2012 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html
>> .
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
>
> Written by Jay Fenlason, Tom Lord, Ken Pizzini,
> and Paolo Bonzini.
> GNU sed home page: <http://www.gnu.org/software/sed/>.
> General help using GNU software: <http://www.gnu.org/gethelp/>.
> E-mail bug reports to: <bug-sed@gnu.org>.
> Be sure to include the word ``sed'' somewhere in the ``Subject:'' field.
>
>
> This will fail on sed version check in configure.ac:
> SED_VERSION=`$SED --version 2>/dev/null | $SED -ne "s/.*version
> \([[0-9\.]]*\)/\1/p"`
>
>
> With command 'sed --version 2>/dev/null | sed -ne "s/.*version
> \([[0-9\.]]*\)/\1/p"' I got following output:
> "3 or later <http://gnu.org/licenses/gpl.html>."
>
> and configure failed with:
> checking sed version... configure: error: we need at least GNU sed 4.x
>
>
> GNU sed gets version string from gnulib see
> http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/version-etc.c;hb=dbed1625626c6d6f271b715f87fd0930d8e68c2f
> beginning at line 43.
>
> I don't see a "version" substring there, maybe it isn't the best way to
> match the sed version.
Since 4.2.1 the output of sed --version changed:
> $ sed --version
> GNU sed version 4.2.1
> Copyright (C) 2009 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE,
> to the extent permitted by law.
>
> GNU sed home page: <http://www.gnu.org/software/sed/>.
> General help using GNU software: <http://www.gnu.org/gethelp/>.
> E-mail bug reports to: <bug-gnu-utils@gnu.org>.
> Be sure to include the word ``sed'' somewhere in the ``Subject:'' field.
Can you please improve the regex to parse both version of sed?
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
[-- Attachment #2: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-31 14:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAKNcqrgFfFzNuxhi8nJBXjoHq9Lmh8t6WFau_uA3gOQQax1H6A@mail.gmail.com>
2014-07-29 13:20 ` [ptxdist] configure failed with sed version 4.2.2 Marc Kleine-Budde
2014-07-29 14:39 ` Kristof Verdonck
2014-07-31 8:34 ` Marc Kleine-Budde
2014-07-31 14:53 ` Kristof Verdonck
2013-01-07 14:19 Alexander Aring
2013-01-07 16:38 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox