From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-yk0-f178.google.com ([209.85.160.178]) by metis.ext.pengutronix.de with esmtps (TLS1.2:RSA_ARCFOUR_SHA1:128) (Exim 4.80) (envelope-from ) id 1ZHSa8-0008Uo-LA for ptxdist@pengutronix.de; Tue, 21 Jul 2015 10:07:21 +0200 Received: by ykax123 with SMTP id x123so161578137yka.1 for ; Tue, 21 Jul 2015 03:06:40 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <55AD1139.4010001@pengutronix.de> References: <1437405096-13826-1-git-send-email-albert@newtec.dk> <55AD1139.4010001@pengutronix.de> Date: Tue, 21 Jul 2015 12:06:40 +0200 Message-ID: From: Albert Antony Subject: Re: [ptxdist] [PATCH] ptxd_install_toolchain_lib: fix "strip" option handling List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0020762732==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: Marc Kleine-Budde --===============0020762732== Content-Type: multipart/alternative; boundary=001a11428146786620051b5fcf91 --001a11428146786620051b5fcf91 Content-Type: text/plain; charset=UTF-8 Sincere apologies for missing that. I'll send along a patch that addresses the "strip" option for library installation in general. Let's abandon this patch. Cheers, Albert. On 20 July 2015 at 17:18, Marc Kleine-Budde wrote: > On 07/20/2015 05:11 PM, Albert Antony wrote: > > The option was not being passed onward, which meant that > > the "strip" parameter passed to install_copy_toolchain_lib > > was getting ignored. > > --- > > scripts/install_copy_toolchain.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/install_copy_toolchain.sh > b/scripts/install_copy_toolchain.sh > > index 0cf4d31..0b70c12 100755 > > --- a/scripts/install_copy_toolchain.sh > > +++ b/scripts/install_copy_toolchain.sh > > @@ -170,7 +170,7 @@ ptxd_install_toolchain_lib() { > > > > perm="$(stat -c %a "${lib_path}")" > > > > - echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 > 0 \"${perm}\"" >> "${STATEDIR}/${packet}.cmds" > > + echo "ptxd_install_shared \"${lib_path}\" \"${prefix}\" 0 > 0 \"${perm}\" \"${strip}\"" >> "${STATEDIR}/${packet}.cmds" > > What difference does it make? > > ptxd_install_shared() { > local src="$1" > local dst="$2" > local usr="$3" > local grp="$4" > local mod="$5" > local filename="$(basename "${src}")" > > > > fi > > else > > echo "error: found ${lib_path}, but neither file nor link" 2>&1 > > > > Marc > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | > > --001a11428146786620051b5fcf91 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Sincere apologies for missing that. I'll send alo= ng a patch that addresses the "strip" option for library installa= tion in general. Let's abandon this patch.

Che= ers,
Albert.


On 20 July 2015 at 17:18, Marc Kleine-Budde= <mkl@pengutronix.de> wrote:
On 07/20/2015 05:11 PM, Albert Antony wrote:
> The option was not being passed onward, which meant that
> the "strip" parameter passed to install_copy_toolchain_lib > was getting ignored.
> ---
>=C2=A0 scripts/install_copy_toolchain.sh | 2 +-
>=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/install_copy_toolchain.sh b/scripts/install_copy_= toolchain.sh
> index 0cf4d31..0b70c12 100755
> --- a/scripts/install_copy_toolchain.sh
> +++ b/scripts/install_copy_toolchain.sh
> @@ -170,7 +170,7 @@ ptxd_install_toolchain_lib() {
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0perm=3D"$(s= tat -c %a "${lib_path}")"
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0echo "ptxd_insta= ll_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${pe= rm}\"" >> "${STATEDIR}/${packet}.cmds"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0echo "ptxd_insta= ll_shared \"${lib_path}\" \"${prefix}\" 0 0 \"${pe= rm}\" \"${strip}\"" >> "${STATEDIR}/${packet= }.cmds"

What difference does it make?

ptxd_install_shared() {
=C2=A0 =C2=A0 local src=3D"$1"
=C2=A0 =C2=A0 local dst=3D"$2"
=C2=A0 =C2=A0 local usr=3D"$3"
=C2=A0 =C2=A0 local grp=3D"$4"
=C2=A0 =C2=A0 local mod=3D"$5"
=C2=A0 =C2=A0 local filename=3D"$(basename "${src}")"


>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fi
>=C2=A0 =C2=A0 =C2=A0 =C2=A0else
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0echo "error: found ${lib_= path}, but neither file nor link" 2>&1
>

Marc
--
Pengutronix e.K.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 | Marc Kleine-Budde=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|
Industrial Linux Solutions=C2=A0 =C2=A0 =C2=A0 =C2=A0 | Phone: +49-231-2826-924=C2=A0 = =C2=A0 =C2=A0|
Vertretung West/Dortmund=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | Fax:=C2=A0 =C2= =A0+49-5= 121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686=C2=A0 | http://www.pengutronix.de=C2= =A0 =C2=A0|


--001a11428146786620051b5fcf91-- --===============0020762732== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline LS0gCnB0eGRpc3QgbWFpbGluZyBsaXN0CnB0eGRpc3RAcGVuZ3V0cm9uaXguZGUK --===============0020762732==--