From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <bruno.thomsen@gmail.com>) id 1jwK8i-0000a1-0L
 for ptxdist@pengutronix.de; Fri, 17 Jul 2020 08:46:36 +0200
Received: by mail-ej1-x641.google.com with SMTP id a21so9617452ejj.10
 for <ptxdist@pengutronix.de>; Thu, 16 Jul 2020 23:46:35 -0700 (PDT)
MIME-Version: 1.0
References: <20200716173805.7467-1-bruno.thomsen@gmail.com>
 <20200716173805.7467-3-bruno.thomsen@gmail.com>
 <20200717063547.GF27485@pengutronix.de>
In-Reply-To: <20200717063547.GF27485@pengutronix.de>
From: Bruno Thomsen <bruno.thomsen@gmail.com>
Date: Fri, 17 Jul 2020 08:46:19 +0200
Message-ID: <CAH+2xPDUTJ1=vSE02VJqtvzakpGapXya9o3AfoEc-qUEV60Cpg@mail.gmail.com>
Subject: Re: [ptxdist] [PATCH 3/5] host-squashfs-tools: add support for zstd
 contitional
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de, Bruno Thomsen <bruno.thomsen@gmail.com>, Bruno Thomsen <bth@kamstrup.com>

Den fre. 17. jul. 2020 kl. 08.35 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Thu, Jul 16, 2020 at 07:38:03PM +0200, Bruno Thomsen wrote:
> > Only enable host zstd package dependency when needed,
> > so it doesn't build unnecessary packages.
> >
> >
> > -HOST_SQUASHFS_TOOLS_MAKE_OPT := LZO_SUPPORT=1 XZ_SUPPORT=1
> > -HOST_SQUASHFS_TOOLS_MAKE_ENV := $(HOST_ENV) EXTRA_LDFLAGS="-L$(PTXDIST_SYSROOT_HOST)/lib/xz"
> > +HOST_SQUASHFS_TOOLS_MAKE_OPT := \
> > +     LZO_SUPPORT=1 \
> > +     XZ_SUPPORT=1 \
> > +     ZSTD_SUPPORT=$(call ptx/ifdef, PTXCONF_IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD,1,0)
> > +
> > +HOST_SQUASHFS_TOOLS_MAKE_ENV := \
> > +     $(HOST_ENV) \
> > +     EXTRA_LDFLAGS="-L$(PTXDIST_SYSROOT_HOST)/lib/xz -L$(PTXDIST_SYSROOT_HOST)/usr/local/lib64" \
> > +     CPPFLAGS="-I$(PTXDIST_SYSROOT_HOST)/usr/local/include"
>
> The /usr/local paths should not be necessary with the fixed host-zstd
> package.

Hi Michael,

Thanks for the review.
It makes sense, I will fix that in the next version.

There are some cross rules optimizations in the next patches,
they remove the compile of some unneeded packages in my example
but it might break something I don't know.

/Bruno

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de