Re: [ptxdist] [PATCH 3/5] host-squashfs-tools: add support for zstd contitional

[Bruno Thomsen <bruno.thomsen@gmail.com>]

Den fre. 17. jul. 2020 kl. 08.35 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Thu, Jul 16, 2020 at 07:38:03PM +0200, Bruno Thomsen wrote:
> > Only enable host zstd package dependency when needed,
> > so it doesn't build unnecessary packages.
> >
> >
> > -HOST_SQUASHFS_TOOLS_MAKE_OPT := LZO_SUPPORT=1 XZ_SUPPORT=1
> > -HOST_SQUASHFS_TOOLS_MAKE_ENV := $(HOST_ENV) EXTRA_LDFLAGS="-L$(PTXDIST_SYSROOT_HOST)/lib/xz"
> > +HOST_SQUASHFS_TOOLS_MAKE_OPT := \
> > +     LZO_SUPPORT=1 \
> > +     XZ_SUPPORT=1 \
> > +     ZSTD_SUPPORT=$(call ptx/ifdef, PTXCONF_IMAGE_ROOT_SQUASHFS_COMPRESSION_MODE_ZSTD,1,0)
> > +
> > +HOST_SQUASHFS_TOOLS_MAKE_ENV := \
> > +     $(HOST_ENV) \
> > +     EXTRA_LDFLAGS="-L$(PTXDIST_SYSROOT_HOST)/lib/xz -L$(PTXDIST_SYSROOT_HOST)/usr/local/lib64" \
> > +     CPPFLAGS="-I$(PTXDIST_SYSROOT_HOST)/usr/local/include"
>
> The /usr/local paths should not be necessary with the fixed host-zstd
> package.

Hi Michael,

Thanks for the review.
It makes sense, I will fix that in the next version.

There are some cross rules optimizations in the next patches,
they remove the compile of some unneeded packages in my example
but it might break something I don't know.

/Bruno

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de