Re: [ptxdist] [PATCH] icu: version bump 74.1 -> 77.1

[Bruno Thomsen <bruno.thomsen@gmail.com>]

Den ons. 15. okt. 2025 kl. 15.08 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Tue, Oct 14, 2025 at 04:59:34PM +0200, Bruno Thomsen wrote:
> > Hi Sven,
> >
> > Great work with all the package maintenance :)
> >
> > Den tirs. 14. okt. 2025 kl. 15.28 skrev Sven Püschel
> > <s.pueschel@pengutronix.de>:
> > >
> > > LICENSE file updates:
> > > - Year was updated
> > > - Unicode-3.0 SPDX Identifier added
> > > - MIT license of a JSON parsing library by Niels Lohmann added
> > >
> > > https://github.com/unicode-org/icu/releases/tag/release-74-2
> > > https://github.com/unicode-org/icu/releases/tag/release-75-1
> > > https://github.com/unicode-org/icu/releases/tag/release-76-1
> > > https://github.com/unicode-org/icu/releases/tag/release-77-1
> > >
> > > Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> > > ---
> > >  rules/icu.make | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/rules/icu.make b/rules/icu.make
> > > index 507de2afe..7a5b4f1ea 100644
> > > --- a/rules/icu.make
> > > +++ b/rules/icu.make
> > > @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_ICU) += icu
> > >  #
> > >  # Paths and names
> > >  #
> > > -ICU_VERSION    := 74.1
> > > -ICU_MD5                := 71e60b22697c4f35820a1897417dbab4
> > > +ICU_VERSION    := 77.1
> > > +ICU_MD5                := bc0132b4c43db8455d2446c3bae58898
> > >  ICU            := icu4c-$(subst .,_,$(ICU_VERSION))-src
> > >  ICU_SUFFIX     := tgz
> > >  ICU_URL                := https://github.com/unicode-org/icu/releases/download/release-$(subst .,-,$(ICU_VERSION))/$(ICU).$(ICU_SUFFIX)
> > > @@ -24,7 +24,7 @@ ICU_DIR               := $(BUILDDIR)/$(ICU)
> > >  ICU_SUBDIR     := source
> > >  ICU_LICENSE    := MIT AND Unicode-3.0 AND public_domain AND BSD-3-Clause
> >
> > public_domain is not a SPDX license identifier.
> > There are a couple of different public domain identifiers, I think
> > it's safe to use CC-PDM-1.0 in this case.
> >
> > Creative Commons Public Domain Mark 1.0 Universal
> > https://spdx.org/licenses/CC-PDM-1.0.html
>
> No. public domain is complicated stuff unfortunately. You cannot just pick
> another on. So a proper identifier would be LicenseRef-icu-public_domain or
> something like that. But that only makes sense if there is a corresponding
> license file.
>

Yes, I know that it's complicated and license identifiers should be as
accurate as possible.
Just looking at it from a we need to generate valid SBOMs soon point of view :)

I was looking at using SPDX License Expressions (
LicenseRef-[idString] ) for proprietary
components in ptxdist like LicenseRef-Acme-corp-proprietary-license.
I did not consider LicenseRef for public_domain, good point.

Just looked up what Fedora[1] has listed the package as and they use
LicenseRef as well:
Unicode-DFS-2016 AND BSD-2-Clause AND BSD-3-Clause AND NAIST-2003 AND
LicenseRef-Fedora-Public-Domain

So just discard my review comment.

/Bruno

[1] https://packages.fedoraproject.org/pkgs/icu/icu/

> I think we should do somthing like this:
>
> ICU_LICENSE_FILES := \
>        file://LICENSE;md5=cf57d9459a2c5f88ecd83c75207cc5ff;startline=nn;endline=mm;id=LicenseRef-icu-public_domain \
>         [...]
>
> But that also means splitting multi-license files...
>
> Maybe with a default id if the filename (minus '.txt' suffix) matches a
> valid SPDX identifier.
>
> Michael
>
> > /Bruno
> >
> > >  ICU_LICENSE_FILES := \
> > > -       file://LICENSE;md5=08dc3852df8fffa807301902ad899ff8
> > > +       file://LICENSE;md5=cf57d9459a2c5f88ecd83c75207cc5ff
> > >
> > >  # ----------------------------------------------------------------------------
> > >  # Prepare
> > > --
> > > 2.47.3
> > >
> > >
> >
> >
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |