From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <bruno.thomsen@gmail.com>) id 1jwJvT-0007NV-UM
 for ptxdist@pengutronix.de; Fri, 17 Jul 2020 08:32:56 +0200
Received: by mail-ed1-x542.google.com with SMTP id dg28so6833268edb.3
 for <ptxdist@pengutronix.de>; Thu, 16 Jul 2020 23:32:55 -0700 (PDT)
MIME-Version: 1.0
References: <20200710155553.6370-1-bruno.thomsen@gmail.com>
 <20200716160935.GA6174@pengutronix.de>
In-Reply-To: <20200716160935.GA6174@pengutronix.de>
From: Bruno Thomsen <bruno.thomsen@gmail.com>
Date: Fri, 17 Jul 2020 08:32:38 +0200
Message-ID: <CAH+2xPD3CFEc72oVTQmqgygx7BmErE=EGASz+6EfLFTxL1Ntww@mail.gmail.com>
Subject: Re: [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT
 commands via DBus
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

Den tor. 16. jul. 2020 kl. 18.10 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Fri, Jul 10, 2020 at 05:55:53PM +0200, Bruno Thomsen wrote:
> > This feature is useful when needing to approve a device
> > under RED directive for the EU market where it's required
> > to use the same firmware that ships to customers during
> > radio testing. As this work typically involves the use of
> > hidden/custom commands not need for every day operation.
> >
> > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > ---
> > v1-v2:
> > rhi: use select DBUS dependency.
> >
> >  rules/modemmanager.in   | 5 +++++
> >  rules/modemmanager.make | 2 +-
> >  2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> > index 50f2d9c6a..179932835 100644
> > --- a/rules/modemmanager.in
> > +++ b/rules/modemmanager.in
> > @@ -2,6 +2,7 @@
> >
> >  menuconfig MODEMMANAGER
> >       tristate
> > +     select DBUS             if MODEMMANAGER_ALLOW_DBUS_AT_CMDS
>
> This is a runtime dependency, not a buildtime dependency, right?

Just tested it and you are right it's only a runtime dependency.
I will send a v3.

>
>         select DBUS             if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de