* [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT commands via DBus
@ 2020-07-10 15:55 Bruno Thomsen
2020-07-16 16:09 ` Michael Olbrich
0 siblings, 1 reply; 3+ messages in thread
From: Bruno Thomsen @ 2020-07-10 15:55 UTC (permalink / raw)
To: ptxdist; +Cc: Bruno Thomsen, rhi, bth
This feature is useful when needing to approve a device
under RED directive for the EU market where it's required
to use the same firmware that ships to customers during
radio testing. As this work typically involves the use of
hidden/custom commands not need for every day operation.
Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
v1-v2:
rhi: use select DBUS dependency.
rules/modemmanager.in | 5 +++++
rules/modemmanager.make | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/rules/modemmanager.in b/rules/modemmanager.in
index 50f2d9c6a..179932835 100644
--- a/rules/modemmanager.in
+++ b/rules/modemmanager.in
@@ -2,6 +2,7 @@
menuconfig MODEMMANAGER
tristate
+ select DBUS if MODEMMANAGER_ALLOW_DBUS_AT_CMDS
select GLIB
select UDEV
select LIBGUDEV
@@ -24,4 +25,8 @@ config MODEMMANAGER_SYSTEMD_UNIT
depends on SYSTEMD
prompt "install systemd unit file"
+config MODEMMANAGER_ALLOW_DBUS_AT_CMDS
+ bool
+ prompt "allow arbitrary AT commands via DBus"
+
endif
diff --git a/rules/modemmanager.make b/rules/modemmanager.make
index b26e47c4a..5cae10024 100644
--- a/rules/modemmanager.make
+++ b/rules/modemmanager.make
@@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT := \
--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \
--$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \
--without-polkit \
- --without-at-command-via-dbus \
+ --$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \
--with-mbim \
--with-qmi
base-commit: 9fe5462616de2ce93663f409f471ea83a6d5fbb5
--
2.26.2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT commands via DBus
2020-07-10 15:55 [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT commands via DBus Bruno Thomsen
@ 2020-07-16 16:09 ` Michael Olbrich
2020-07-17 6:32 ` Bruno Thomsen
0 siblings, 1 reply; 3+ messages in thread
From: Michael Olbrich @ 2020-07-16 16:09 UTC (permalink / raw)
To: ptxdist
On Fri, Jul 10, 2020 at 05:55:53PM +0200, Bruno Thomsen wrote:
> This feature is useful when needing to approve a device
> under RED directive for the EU market where it's required
> to use the same firmware that ships to customers during
> radio testing. As this work typically involves the use of
> hidden/custom commands not need for every day operation.
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> v1-v2:
> rhi: use select DBUS dependency.
>
> rules/modemmanager.in | 5 +++++
> rules/modemmanager.make | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> index 50f2d9c6a..179932835 100644
> --- a/rules/modemmanager.in
> +++ b/rules/modemmanager.in
> @@ -2,6 +2,7 @@
>
> menuconfig MODEMMANAGER
> tristate
> + select DBUS if MODEMMANAGER_ALLOW_DBUS_AT_CMDS
This is a runtime dependency, not a buildtime dependency, right?
select DBUS if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME
Michael
> select GLIB
> select UDEV
> select LIBGUDEV
> @@ -24,4 +25,8 @@ config MODEMMANAGER_SYSTEMD_UNIT
> depends on SYSTEMD
> prompt "install systemd unit file"
>
> +config MODEMMANAGER_ALLOW_DBUS_AT_CMDS
> + bool
> + prompt "allow arbitrary AT commands via DBus"
> +
> endif
> diff --git a/rules/modemmanager.make b/rules/modemmanager.make
> index b26e47c4a..5cae10024 100644
> --- a/rules/modemmanager.make
> +++ b/rules/modemmanager.make
> @@ -50,7 +50,7 @@ MODEMMANAGER_CONF_OPT := \
> --$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-suspend-resume \
> --$(call ptx/wwo, PTXCONF_INITMETHOD_SYSTEMD)-systemd-journal \
> --without-polkit \
> - --without-at-command-via-dbus \
> + --$(call ptx/wwo, PTXCONF_MODEMMANAGER_ALLOW_DBUS_AT_CMDS)-at-command-via-dbus \
> --with-mbim \
> --with-qmi
>
>
> base-commit: 9fe5462616de2ce93663f409f471ea83a6d5fbb5
> --
> 2.26.2
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT commands via DBus
2020-07-16 16:09 ` Michael Olbrich
@ 2020-07-17 6:32 ` Bruno Thomsen
0 siblings, 0 replies; 3+ messages in thread
From: Bruno Thomsen @ 2020-07-17 6:32 UTC (permalink / raw)
To: ptxdist
Den tor. 16. jul. 2020 kl. 18.10 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Fri, Jul 10, 2020 at 05:55:53PM +0200, Bruno Thomsen wrote:
> > This feature is useful when needing to approve a device
> > under RED directive for the EU market where it's required
> > to use the same firmware that ships to customers during
> > radio testing. As this work typically involves the use of
> > hidden/custom commands not need for every day operation.
> >
> > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > ---
> > v1-v2:
> > rhi: use select DBUS dependency.
> >
> > rules/modemmanager.in | 5 +++++
> > rules/modemmanager.make | 2 +-
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> > index 50f2d9c6a..179932835 100644
> > --- a/rules/modemmanager.in
> > +++ b/rules/modemmanager.in
> > @@ -2,6 +2,7 @@
> >
> > menuconfig MODEMMANAGER
> > tristate
> > + select DBUS if MODEMMANAGER_ALLOW_DBUS_AT_CMDS
>
> This is a runtime dependency, not a buildtime dependency, right?
Just tested it and you are right it's only a runtime dependency.
I will send a v3.
>
> select DBUS if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-17 6:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-10 15:55 [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT commands via DBus Bruno Thomsen
2020-07-16 16:09 ` Michael Olbrich
2020-07-17 6:32 ` Bruno Thomsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox