Re: [ptxdist] [PATCH v2] modemmanager: config: allow arbitrary AT commands via DBus

[Bruno Thomsen <bruno.thomsen@gmail.com>]

Den tor. 16. jul. 2020 kl. 18.10 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Fri, Jul 10, 2020 at 05:55:53PM +0200, Bruno Thomsen wrote:
> > This feature is useful when needing to approve a device
> > under RED directive for the EU market where it's required
> > to use the same firmware that ships to customers during
> > radio testing. As this work typically involves the use of
> > hidden/custom commands not need for every day operation.
> >
> > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > ---
> > v1-v2:
> > rhi: use select DBUS dependency.
> >
> >  rules/modemmanager.in   | 5 +++++
> >  rules/modemmanager.make | 2 +-
> >  2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> > index 50f2d9c6a..179932835 100644
> > --- a/rules/modemmanager.in
> > +++ b/rules/modemmanager.in
> > @@ -2,6 +2,7 @@
> >
> >  menuconfig MODEMMANAGER
> >       tristate
> > +     select DBUS             if MODEMMANAGER_ALLOW_DBUS_AT_CMDS
>
> This is a runtime dependency, not a buildtime dependency, right?

Just tested it and you are right it's only a runtime dependency.
I will send a v3.

>
>         select DBUS             if MODEMMANAGER_ALLOW_DBUS_AT_CMDS && RUNTIME

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de