From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <bruno.thomsen@gmail.com>) id 1j52UY-0004Kt-Kd
 for ptxdist@pengutronix.de; Fri, 21 Feb 2020 08:12:55 +0100
Received: by mail-ed1-x542.google.com with SMTP id p14so1088373edy.13
 for <ptxdist@pengutronix.de>; Thu, 20 Feb 2020 23:12:54 -0800 (PST)
MIME-Version: 1.0
References: <20200220111756.16577-1-p.zabel@pengutronix.de>
In-Reply-To: <20200220111756.16577-1-p.zabel@pengutronix.de>
From: Bruno Thomsen <bruno.thomsen@gmail.com>
Date: Fri, 21 Feb 2020 08:12:37 +0100
Message-ID: <CAH+2xPD1EZD47W-ifg-ApVKuTH2_9GtFW78MNNm1Qz-hqB0GEA@mail.gmail.com>
Subject: Re: [ptxdist] [PATCH v2] zstd: new package
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Florian Faber <faber@faberman.de>

Hi

Den tor. 20. feb. 2020 kl. 12.20 skrev Philipp Zabel <p.zabel@pengutronix.de>:
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/zstd.targetinstall:
> +       @$(call targetinfo)

This section did not work in my test as indentation is space and not tab.

/home/developer/git/ptxdist/rules/zstd.make:55: *** missing separator.  Stop.

> +
> +       @$(call install_init, zstd)
> +       @$(call install_fixup, zstd, PRIORITY, optional)
> +       @$(call install_fixup, zstd, SECTION, base)
> +       @$(call install_fixup, zstd, AUTHOR, "Florian Faber <faber@faberman.de>")
> +       @$(call install_fixup, zstd, DESCRIPTION, missing)
> +
> +ifdef PTXCONF_ZSTD_LIBZSTD
> +       $(call install_lib, zstd, 0, 0, 0644, libzstd)

Target-Install lines normally starts with @, e.g.
@$(call install_lib, zstd, 0, 0, 0644, libzstd)

Same for the next 6 lines.

Bruno

> +endif
> +ifdef PTXCONF_ZSTD_ZSTD
> +       $(call install_copy, zstd, 0, 0, 0755, -, /usr/bin/zstd)
> +       $(call install_link, zstd, zstd, /usr/bin/zstdcat)
> +       $(call install_link, zstd, zstd, /usr/bin/zstdmt)
> +       $(call install_link, zstd, zstd, /usr/bin/unzstd)
> +endif
> +ifdef PTXCONF_ZSTD_ZSTDGREP
> +       $(call install_copy, zstd, 0, 0, 0755, -, /usr/bin/zstdgrep)
> +endif
> +ifdef PTXCONF_ZSTD_ZSTDLESS
> +       $(call install_copy, zstd, 0, 0, 0755, -, /usr/bin/zstdless)
> +endif
> +
> +       @$(call install_finish, zstd)
> +
> +       @$(call touch)
> --
> 2.20.1
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de