mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: ptxdist@pengutronix.de
Cc: Florian Faber <faber@faberman.de>
Subject: Re: [ptxdist] [PATCH v2] zstd: new package
Date: Fri, 21 Feb 2020 08:12:37 +0100	[thread overview]
Message-ID: <CAH+2xPD1EZD47W-ifg-ApVKuTH2_9GtFW78MNNm1Qz-hqB0GEA@mail.gmail.com> (raw)
In-Reply-To: <20200220111756.16577-1-p.zabel@pengutronix.de>

Hi

Den tor. 20. feb. 2020 kl. 12.20 skrev Philipp Zabel <p.zabel@pengutronix.de>:
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/zstd.targetinstall:
> +       @$(call targetinfo)

This section did not work in my test as indentation is space and not tab.

/home/developer/git/ptxdist/rules/zstd.make:55: *** missing separator.  Stop.

> +
> +       @$(call install_init, zstd)
> +       @$(call install_fixup, zstd, PRIORITY, optional)
> +       @$(call install_fixup, zstd, SECTION, base)
> +       @$(call install_fixup, zstd, AUTHOR, "Florian Faber <faber@faberman.de>")
> +       @$(call install_fixup, zstd, DESCRIPTION, missing)
> +
> +ifdef PTXCONF_ZSTD_LIBZSTD
> +       $(call install_lib, zstd, 0, 0, 0644, libzstd)

Target-Install lines normally starts with @, e.g.
@$(call install_lib, zstd, 0, 0, 0644, libzstd)

Same for the next 6 lines.

Bruno

> +endif
> +ifdef PTXCONF_ZSTD_ZSTD
> +       $(call install_copy, zstd, 0, 0, 0755, -, /usr/bin/zstd)
> +       $(call install_link, zstd, zstd, /usr/bin/zstdcat)
> +       $(call install_link, zstd, zstd, /usr/bin/zstdmt)
> +       $(call install_link, zstd, zstd, /usr/bin/unzstd)
> +endif
> +ifdef PTXCONF_ZSTD_ZSTDGREP
> +       $(call install_copy, zstd, 0, 0, 0755, -, /usr/bin/zstdgrep)
> +endif
> +ifdef PTXCONF_ZSTD_ZSTDLESS
> +       $(call install_copy, zstd, 0, 0, 0755, -, /usr/bin/zstdless)
> +endif
> +
> +       @$(call install_finish, zstd)
> +
> +       @$(call touch)
> --
> 2.20.1
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2020-02-21  7:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 11:17 Philipp Zabel
2020-02-21  7:12 ` Bruno Thomsen [this message]
2020-02-21  7:54   ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH+2xPD1EZD47W-ifg-ApVKuTH2_9GtFW78MNNm1Qz-hqB0GEA@mail.gmail.com \
    --to=bruno.thomsen@gmail.com \
    --cc=faber@faberman.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox