* [ptxdist] [PATCH] u-boot: bugfix: trigger recompile on Kconfig changes
@ 2019-12-06 18:02 Bruno Thomsen
2019-12-07 12:27 ` Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Bruno Thomsen @ 2019-12-06 18:02 UTC (permalink / raw)
To: ptxdist; +Cc: Bruno Thomsen, bth
When using the modern Kconfig as config system, changes to
the config file did not trigger a rebuild of the image.
Steps to reproduce:
$ ptxdist targetinstall u-boot
<image is build>
$ ptxdist menuconfig u-boot
<change any option>
$ ptxdist targetinstall u-boot
<all up-to-date>
Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
rules/u-boot.make | 1 +
1 file changed, 1 insertion(+)
diff --git a/rules/u-boot.make b/rules/u-boot.make
index 04d801fc6..4a4bd3f85 100644
--- a/rules/u-boot.make
+++ b/rules/u-boot.make
@@ -30,6 +30,7 @@ U_BOOT_BUILD_OOT := KEEP
ifdef PTXCONF_U_BOOT_CONFIGSYSTEM_KCONFIG
U_BOOT_CONFIG := $(call ptx/in-platformconfigdir, \
$(call remove_quotes, $(PTXCONF_U_BOOT_CONFIGFILE_KCONFIG)))
+$(STATEDIR)/u-boot.compile: $(U_BOOT_CONFIG)
endif
# ----------------------------------------------------------------------------
--
2.23.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] u-boot: bugfix: trigger recompile on Kconfig changes
2019-12-06 18:02 [ptxdist] [PATCH] u-boot: bugfix: trigger recompile on Kconfig changes Bruno Thomsen
@ 2019-12-07 12:27 ` Michael Olbrich
2019-12-09 7:34 ` Bruno Thomsen
0 siblings, 1 reply; 4+ messages in thread
From: Michael Olbrich @ 2019-12-07 12:27 UTC (permalink / raw)
To: ptxdist; +Cc: Bruno Thomsen, bth
On Fri, Dec 06, 2019 at 07:02:44PM +0100, Bruno Thomsen wrote:
> When using the modern Kconfig as config system, changes to
> the config file did not trigger a rebuild of the image.
>
> Steps to reproduce:
> $ ptxdist targetinstall u-boot
> <image is build>
> $ ptxdist menuconfig u-boot
> <change any option>
> $ ptxdist targetinstall u-boot
> <all up-to-date>
With which ptxdist version? I cannot reproduce this with master.
Changes to the config file change the u-boot.*.cfghash and trigger the
rebuild.
Michael
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> rules/u-boot.make | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index 04d801fc6..4a4bd3f85 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -30,6 +30,7 @@ U_BOOT_BUILD_OOT := KEEP
> ifdef PTXCONF_U_BOOT_CONFIGSYSTEM_KCONFIG
> U_BOOT_CONFIG := $(call ptx/in-platformconfigdir, \
> $(call remove_quotes, $(PTXCONF_U_BOOT_CONFIGFILE_KCONFIG)))
> +$(STATEDIR)/u-boot.compile: $(U_BOOT_CONFIG)
> endif
>
> # ----------------------------------------------------------------------------
> --
> 2.23.0
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] u-boot: bugfix: trigger recompile on Kconfig changes
2019-12-07 12:27 ` Michael Olbrich
@ 2019-12-09 7:34 ` Bruno Thomsen
2019-12-10 9:30 ` Bruno Thomsen
0 siblings, 1 reply; 4+ messages in thread
From: Bruno Thomsen @ 2019-12-09 7:34 UTC (permalink / raw)
To: ptxdist, Bruno Thomsen, bth
Hi Michael
Den lør. 7. dec. 2019 kl. 13.27 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Fri, Dec 06, 2019 at 07:02:44PM +0100, Bruno Thomsen wrote:
> > When using the modern Kconfig as config system, changes to
> > the config file did not trigger a rebuild of the image.
> >
> > Steps to reproduce:
> > $ ptxdist targetinstall u-boot
> > <image is build>
> > $ ptxdist menuconfig u-boot
> > <change any option>
> > $ ptxdist targetinstall u-boot
> > <all up-to-date>
>
> With which ptxdist version? I cannot reproduce this with master.
> Changes to the config file change the u-boot.*.cfghash and trigger the
> rebuild.
I am using ptxdist-2019.10.1 with u-boot rule from master on a Fedora
30 host and OSELAS.Toolchain-2018.12.0.
Bruno
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] u-boot: bugfix: trigger recompile on Kconfig changes
2019-12-09 7:34 ` Bruno Thomsen
@ 2019-12-10 9:30 ` Bruno Thomsen
0 siblings, 0 replies; 4+ messages in thread
From: Bruno Thomsen @ 2019-12-10 9:30 UTC (permalink / raw)
To: ptxdist, Bruno Thomsen, bth
> > With which ptxdist version? I cannot reproduce this with master.
> > Changes to the config file change the u-boot.*.cfghash and trigger the
> > rebuild.
>
> I am using ptxdist-2019.10.1 with u-boot rule from master on a Fedora
> 30 host and OSELAS.Toolchain-2018.12.0.
Just forget about the patch.
I did a complete "git clean" and not just "ptxdist clean", and now the
issue is gone.
Bruno
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-10 9:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 18:02 [ptxdist] [PATCH] u-boot: bugfix: trigger recompile on Kconfig changes Bruno Thomsen
2019-12-07 12:27 ` Michael Olbrich
2019-12-09 7:34 ` Bruno Thomsen
2019-12-10 9:30 ` Bruno Thomsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox