From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <bruno.thomsen@gmail.com>) id 1jsh4A-0000QO-KM
 for ptxdist@pengutronix.de; Tue, 07 Jul 2020 08:26:55 +0200
Received: by mail-ed1-x543.google.com with SMTP id b15so37394523edy.7
 for <ptxdist@pengutronix.de>; Mon, 06 Jul 2020 23:26:54 -0700 (PDT)
MIME-Version: 1.0
References: <20200706152441.4200-1-bruno.thomsen@gmail.com>
 <20200706165610.GD19479@pengutronix.de>
In-Reply-To: <20200706165610.GD19479@pengutronix.de>
From: Bruno Thomsen <bruno.thomsen@gmail.com>
Date: Tue, 7 Jul 2020 08:26:37 +0200
Message-ID: <CAH+2xPCp48Aap9QQ6AaP8oKpSkCS_dJrKWUkN6=V66RZbfbZGQ@mail.gmail.com>
Subject: Re: [ptxdist] [PATCH] bugfix: kernel: install modules with 755
 permission
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

Den man. 6. jul. 2020 kl. 18.56 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Mon, Jul 06, 2020 at 05:24:41PM +0200, Bruno Thomsen wrote:
> > Added install_copy fixes errors like this:
> >
> > Incompatible ownership or permissions for '/usr/lib/modules/5.6.13-gb44726ddbb7c':
> > kernel-modules: 0.0 0755 (implicit from /usr/lib/modules/5.6.13-gb44726ddbb7c/kernel/net/ipv6/ip6_udp_tunnel.ko)
> > kernel-modules: 0.0 0775
>
> Hmmm, you're running ptxdist with a 0002 umask, right?[1]
>
> Also, the fix is not clear to me. The error is for
> /usr/lib/modules/5.6.13-gb44726ddbb7c but you're creating
> /usr/lib/modules explicitly. How does that fix the problem?
>

I have done some more testing and you are right, the added install_copy
can be dropped. It also works with only the updated install_globs.

Yes, I am running ptxdist with 0002 umask as a user.

On Fedora users run with 0002 umask and root runs with 0022 umask,
but ptxdist does not support building as root, e.g. rootless
containers (podman).

$ podman run --rm -it fedora:32
[root@7940c80a5df2 /]# whoami
root
[root@7940c80a5df2 /]# umask
0022

So requiring that umask seems a little counter intuitive to me.

/Bruno

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de