mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] bugfix: kernel: install modules with 755 permission
Date: Tue, 7 Jul 2020 08:26:37 +0200	[thread overview]
Message-ID: <CAH+2xPCp48Aap9QQ6AaP8oKpSkCS_dJrKWUkN6=V66RZbfbZGQ@mail.gmail.com> (raw)
In-Reply-To: <20200706165610.GD19479@pengutronix.de>

Den man. 6. jul. 2020 kl. 18.56 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Mon, Jul 06, 2020 at 05:24:41PM +0200, Bruno Thomsen wrote:
> > Added install_copy fixes errors like this:
> >
> > Incompatible ownership or permissions for '/usr/lib/modules/5.6.13-gb44726ddbb7c':
> > kernel-modules: 0.0 0755 (implicit from /usr/lib/modules/5.6.13-gb44726ddbb7c/kernel/net/ipv6/ip6_udp_tunnel.ko)
> > kernel-modules: 0.0 0775
>
> Hmmm, you're running ptxdist with a 0002 umask, right?[1]
>
> Also, the fix is not clear to me. The error is for
> /usr/lib/modules/5.6.13-gb44726ddbb7c but you're creating
> /usr/lib/modules explicitly. How does that fix the problem?
>

I have done some more testing and you are right, the added install_copy
can be dropped. It also works with only the updated install_globs.

Yes, I am running ptxdist with 0002 umask as a user.

On Fedora users run with 0002 umask and root runs with 0022 umask,
but ptxdist does not support building as root, e.g. rootless
containers (podman).

$ podman run --rm -it fedora:32
[root@7940c80a5df2 /]# whoami
root
[root@7940c80a5df2 /]# umask
0022

So requiring that umask seems a little counter intuitive to me.

/Bruno

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2020-07-07  6:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 15:24 Bruno Thomsen
2020-07-06 16:56 ` Michael Olbrich
2020-07-07  6:26   ` Bruno Thomsen [this message]
2020-07-07 10:06     ` Michael Olbrich
2020-07-07 10:56       ` Bruno Thomsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+2xPCp48Aap9QQ6AaP8oKpSkCS_dJrKWUkN6=V66RZbfbZGQ@mail.gmail.com' \
    --to=bruno.thomsen@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox