From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v3] u-boot: generate environment image
Date: Fri, 22 Nov 2019 16:49:16 +0100 [thread overview]
Message-ID: <CAH+2xPCcnHfajNkYotQjjWq-ek=ihD=TeMZWbF7Pmhc_CzNUPw@mail.gmail.com> (raw)
In-Reply-To: <20191122141435.GF1287@pengutronix.de>
Ups, version 4 was send before I saw your email.
> > ifdef PTXCONF_U_BOOT_CUSTOM_ENV_IMAGE
> > U_BOOT_CUSTOM_ENV_SRC := $(call ptx/in-platformconfigdir, \
> > $(PTXCONF_U_BOOT_CUSTOM_ENV_IMAGE_SOURCE))
>
> You need the remove_quotes here for PTXCONF_U_BOOT_CUSTOM_ENV_IMAGE_SOURCE.
> Other than that, this should work correctly with layers.
>
> > $(STATEDIR)/u-boot.compile: $(call remove_quotes, $(U_BOOT_CUSTOM_ENV_SRC))
>
> No need for remove_quotes here.
Okay, thanks for input Michael.
I will update the patch Monday.
/Bruno
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2019-11-22 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 16:40 Bruno Thomsen
2019-11-20 8:10 ` Alexander Dahl
2019-11-22 13:31 ` Bruno Thomsen
2019-11-22 14:14 ` Michael Olbrich
2019-11-22 15:49 ` Bruno Thomsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+2xPCcnHfajNkYotQjjWq-ek=ihD=TeMZWbF7Pmhc_CzNUPw@mail.gmail.com' \
--to=bruno.thomsen@gmail.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox