Re: [ptxdist] [PATCH 2/3] autossh: add license file and hash

[Bruno Thomsen <bruno.thomsen@gmail.com>]

Den fre. 15. mar. 2024 kl. 07.30 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Fri, Mar 08, 2024 at 06:16:17PM +0100, Bruno Thomsen wrote:
> > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > ---
> >  rules/autossh.make | 18 ++++++++++--------
> >  1 file changed, 10 insertions(+), 8 deletions(-)
> >
> > diff --git a/rules/autossh.make b/rules/autossh.make
> > index 879cd1c99..19512070e 100644
> > --- a/rules/autossh.make
> > +++ b/rules/autossh.make
> > @@ -14,14 +14,16 @@ PACKAGES-$(PTXCONF_AUTOSSH) += autossh
> >  #
> >  # Paths and names
> >  #
> > -AUTOSSH_VERSION      := 1.4c
> > -AUTOSSH_MD5  := 26520eea934f296be0783dabe7fcfd28
> > -AUTOSSH              := autossh-$(AUTOSSH_VERSION)
> > -AUTOSSH_SUFFIX       := tgz
> > -AUTOSSH_URL  := https://www.harding.motd.ca/autossh/$(AUTOSSH).$(AUTOSSH_SUFFIX)
> > -AUTOSSH_SOURCE       := $(SRCDIR)/$(AUTOSSH).$(AUTOSSH_SUFFIX)
> > -AUTOSSH_DIR  := $(BUILDDIR)/$(AUTOSSH)
> > -AUTOSSH_LICENSE      := unknown
> > +AUTOSSH_VERSION              := 1.4c
> > +AUTOSSH_MD5          := 26520eea934f296be0783dabe7fcfd28
> > +AUTOSSH                      := autossh-$(AUTOSSH_VERSION)
> > +AUTOSSH_SUFFIX               := tgz
> > +AUTOSSH_URL          := https://www.harding.motd.ca/autossh/$(AUTOSSH).$(AUTOSSH_SUFFIX)
> > +AUTOSSH_SOURCE               := $(SRCDIR)/$(AUTOSSH).$(AUTOSSH_SUFFIX)
> > +AUTOSSH_DIR          := $(BUILDDIR)/$(AUTOSSH)
> > +AUTOSSH_LICENSE              := unknown
>
> If there is no patching spdx identifier, then use 'custom' for the license.
> 'unknown' means, nobody looked at it.

Thanks for the review.
I overlooked that difference but can see that it's in the documentation.

>
> > +AUTOSSH_LICENSE_FILES        := \
> > +     file://LICENSE;md5=799b1a7511fc918ee7de7122e1a538b5
>
> I'm not seeing a LICENSE file in the source package.

Let's just squash patch 2 and 3 with removal of the unknown
license tag.

/Bruno

>
> Michael
>
> >
> >  # ----------------------------------------------------------------------------
> >  # Prepare
> > --
> > 2.44.0
> >
> >
> >
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |