Re: [ptxdist] [PATCH v2] u-boot: generate environment image

[Bruno Thomsen <bruno.thomsen@gmail.com>]

Hi

Den man. 18. nov. 2019 kl. 09.43 skrev Denis OSTERLAND
<denis.osterland@diehl.com>:
>
> Hi,
>
> Am Freitag, den 15.11.2019, 14:59 +0100 schrieb Michael Olbrich:
> > On Wed, Nov 13, 2019 at 06:05:59PM +0100, Bruno Thomsen wrote:
> ...
> > > +config U_BOOT_DEFAULT_ENV_IMAGE_FILE
> > > +   prompt "Default environment image filename"
> > > +   string
> > > +   default "u-boot-env.img"
> > > +   help
> > > +     Change default environment output image name.
> >
> > Why the custom name? It's just the filename in images/ and it can be
> > changed wenn it's added to an image, if that's necessary.
> > If it's important, then the option should depend on
> > U_BOOT_DEFAULT_ENV_IMAGE

So it's easier to tell what environment image you flashing.

We use the image directly from images/ and does not create a
combined device image, but will remove both image names in
next version.

> > Denis, I think you were asking for a selectable input file, not generating
> > multiple env images?
> correct.
> I see no reason to have both files, or to specify the output file name.
> My suggestion was to give a filename or generate it via get_default_envs.sh if none given.
> If you want to be more explicit, I would prefer a choice between default and custom,
> where the filename depends on the custom selected.

I just overdid the function and will revert it to a simple choice between
none, default and custom.

> > And the same issue as above, if this stays: do we need to custom output
> > filename and hide the suboptions with 'depends'.

Will hide custom source file when choice is none or default.

/Bruno

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de